fix(#7623): Resize ConductorAxis properly #7624
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7624 +/- ##
==========================================
+ Coverage 56.14% 56.19% +0.04%
==========================================
Files 672 672
Lines 27128 27133 +5
Branches 2635 2635
==========================================
+ Hits 15231 15247 +16
+ Misses 11569 11559 -10
+ Partials 328 327 -1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -55,20 +57,69 @@ export default { | |||
| } | |||
| }, | |||
| emits: ['pan-axis', 'end-pan', 'zoom-axis', 'end-zoom'], | |||
| setup() { | |||
| const axisHolder = ref(null); | |||
There was a problem hiding this comment.
this all looks very familiar 😀
|
Wait to merge, have a visual test inc |
Yeah, figured. I was going to suggest that but my brain shorted. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7624 +/- ##
==========================================
- Coverage 56.31% 56.30% -0.01%
==========================================
Files 672 672
Lines 27114 27120 +6
Branches 2632 2632
==========================================
+ Hits 15269 15270 +1
- Misses 11517 11522 +5
Partials 328 328
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| expect(time).toBe(MISSION_TIME + 1000 * 1); | ||
| await tick(1000); | ||
| time = await page.evaluate(() => new Date().getTime()); | ||
| expect(time).toBe(MISSION_TIME + 1000 * 2); |
Closes #7623
Describe your changes:
e2e Framework Changes:
page.screenshot()passing in defaults that may apply to most Open MCT snapshot tests (mask timestamps, disable animations). These can be overridden in the test by passing an options object as normal.tick()that is meant to be used in conjunction withoverrideClock. This allows tests that have paused clock (shouldAdvanceTime: false) to be able to manually tick the clock to trigger ui updates, router params updates, etc.All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist