Skip to content

Resize plans properly #7597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Resize plans properly #7597

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8533d3e
resize firing
scottbell Mar 15, 2024
392fe7b
ensure watcher fires
scottbell Mar 15, 2024
0fdeffb
remove unneeded const
scottbell Mar 18, 2024
792b189
add small visual test resizing plan
scottbell Mar 18, 2024
f878795
Merge branch 'master' into 7587-resizing-the-window-causes-plan-activ…
scottbell Mar 18, 2024
86eedac
use browser with null viewport
scottbell Mar 18, 2024
e4250d3
lint
scottbell Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/ui/components/TimeSystemAxis.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,13 @@
},
setup() {
const axisHolder = ref(null);
const { size, startObserving } = useResizeObserver();
const { size: containerSize, startObserving } = useResizeObserver();
onMounted(() => {
startObserving(axisHolder.value);
});
return {
containerSize: size
axisHolder,
containerSize
};
},
watch: {
Expand All @@ -95,16 +96,19 @@
contentHeight() {
this.updateNowMarker();
},
containerSize() {
this.resize();
containerSize: {
handler() {
this.resize();

Check warning on line 101 in src/ui/components/TimeSystemAxis.vue

View check run for this annotation

Codecov / codecov/patch

src/ui/components/TimeSystemAxis.vue#L101 

Added line #L101 was not covered by tests
},
deep: true
}
},
mounted() {
if (this.renderingEngine === 'svg') {
this.useSVG = true;
}

this.container = select(this.$refs.axisHolder);
this.container = select(this.axisHolder);
this.svgElement = this.container.append('svg:svg');
// draw x axis with labels. CSS is used to position them.
this.axisElement = this.svgElement
Expand All @@ -122,7 +126,7 @@
},
methods: {
resize() {
if (this.$refs.axisHolder.clientWidth !== this.width) {
if (this.axisHolder.clientWidth !== this.width) {
this.setDimensions();
this.drawAxis(this.bounds, this.timeSystem);
this.updateNowMarker();
Expand All @@ -139,7 +143,7 @@
}
},
setDimensions() {
const axisHolder = this.$refs.axisHolder;
const axisHolder = this.axisHolder;
this.width = axisHolder.clientWidth;
this.offsetWidth = this.width - this.offset;

Expand Down
Loading