Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Temp disable flakefinder as we it's generating too many GHA minutes #7548

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

unlikelyzero
Copy link
Collaborator

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes Notable Change ? For example, will this break compatibility with existing APIs or projects which source these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@unlikelyzero unlikelyzero requested a review from ozyx March 5, 2024 01:42
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Mar 5, 2024
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.25%. Comparing base (39ab81c) to head (151f9ca).

❗ Current head 151f9ca differs from pull request most recent head d10f21d. Consider uploading reports for the commit d10f21d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7548      +/-   ##
==========================================
- Coverage   55.27%   55.25%   -0.02%     
==========================================
  Files         672      672              
  Lines       26965    26969       +4     
  Branches     2622     2622              
==========================================
- Hits        14904    14903       -1     
- Misses      11340    11346       +6     
+ Partials      721      720       -1     
Flag Coverage Δ
e2e-full 23.32% <ø> (ø)
e2e-stable 59.39% <ø> (-0.15%) ⬇️
unit 48.55% <ø> (-0.01%) ⬇️

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ab81c...d10f21d. Read the comment docs.

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@unlikelyzero unlikelyzero marked this pull request as ready for review March 5, 2024 02:31
@unlikelyzero unlikelyzero merged commit 5d00d64 into master Mar 5, 2024
3 of 9 checks passed
@unlikelyzero unlikelyzero deleted the temp-disable-flakefinder branch March 5, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants