Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all logic around auto centering and scrolling the timelist #7474

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Feb 5, 2024

Closes #7449

Describe your changes:

Remove auto scrolling for time list

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@shefalijoshi shefalijoshi added this to the Target:4.0.0 milestone Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29d83e9) 55.60% compared to head (bab84ad) 55.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7474      +/-   ##
==========================================
- Coverage   55.60%   55.13%   -0.47%     
==========================================
  Files         672      672              
  Lines       27026    26961      -65     
  Branches     2634     2620      -14     
==========================================
- Hits        15027    14866     -161     
- Misses      11274    11377     +103     
+ Partials      725      718       -7     
Flag Coverage Δ
e2e-full 21.69% <ø> (-28.11%) ⬇️
e2e-stable 59.30% <ø> (-0.23%) ⬇️
unit 48.47% <ø> (+<0.01%) ⬆️
Files Coverage Δ
src/plugins/timelist/TimelistComponent.vue 61.80% <ø> (+4.99%) ⬆️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d83e9...bab84ad. Read the comment docs.

@unlikelyzero unlikelyzero added the notable_change A change which should be noted in the changelog label Feb 5, 2024
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Feb 6, 2024
@unlikelyzero unlikelyzero added type:bug and removed type:maintenance tests, chores, or project maintenance labels Feb 21, 2024
@ozyx ozyx self-requested a review February 21, 2024 23:09
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 22, 2024
@ozyx ozyx enabled auto-merge (squash) February 22, 2024 17:24
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 22, 2024
@ozyx ozyx merged commit dc9bd8b into master Feb 22, 2024
21 of 22 checks passed
@ozyx ozyx deleted the remove-auto-centering-timelist branch February 22, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable_change A change which should be noted in the changelog type:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time List auto-centering is problematic and should be removed
3 participants