Ensure previews work for plots #7459
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7459 +/- ##
==========================================
- Coverage 55.37% 51.85% -3.53%
==========================================
Files 671 671
Lines 26920 26930 +10
Branches 2614 2614
==========================================
- Hits 14908 13964 -944
- Misses 11297 12250 +953
- Partials 715 716 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 124 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
scottbell
changed the title
| @@ -61,6 +61,7 @@ class Overlay extends EventEmitter { | |||
| dismiss() { | |||
| this.emit('destroy'); | |||
| this.destroy(); | |||
| this.container.remove(); | |||
There was a problem hiding this comment.
overlays were stacking up!
| root: rootContainer, | ||
| rootMargin: '0px', | ||
| threshold: 1.0 | ||
| root: rootContainer |
There was a problem hiding this comment.
we need defaults here (specifically the 0 threshold) so our callback runs when the whole canvas is gone, or if a single pixel of the canvas is visible. this keeps the intersection conservative in its definition of "visible"
| if (!this.chartVisible) { | ||
| // destroy the chart | ||
| const isNowVisible = entry.isIntersecting; | ||
| const chartInOverlayWindow = this.chartContainer?.closest('.js-overlay') !== null; |
There was a problem hiding this comment.
intersection observers in previews behave badly as the overlay covers our root element! try to detect that we're in one.
| element: vNode.el, | ||
| size: 'large', | ||
| autoHide: false, | ||
| buttons: [ | ||
| { | ||
| label: 'Done', | ||
| callback: () => overlay.dismiss() | ||
| callback: () => { | ||
| overlay.dismiss(); |
There was a problem hiding this comment.
overlays were stacking up!
| #observerCallback = ([entry]) => { | ||
| if (entry.target === this.#element) { | ||
| this.isIntersecting = entry.isIntersecting; | ||
| if (this.#inOverlay() && !entry.isIntersecting) { |
There was a problem hiding this comment.
same issue as renderWhenVisible
e2e/tests/functional/plugins/displayLayout/displayLayout.e2e.spec.js
Outdated
Show resolved
Hide resolved
scottbell
added
pr:e2e:couchdb
scottbell
deleted the
7446-large-view-for-telemetry-doesnt-show-any-plot
branch
Closes #7446
Closes #7535
Describe your changes:
renderWhenVisiblefunction always firesAll Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist