Mct7367-tests #7387

unlikelyzero · 2024-01-18T19:11:27Z

Describe your changes:

Tests for the #7367 feature

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

Changes address original issue?
Tests included and/or updated with changes?
Has this been smoke tested?
Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
Have you associated a milestone with this PR? Note: leave blank if unsure.
Is this a breaking change to be called out in the release notes?
Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

Changes appear to address issue?
Reviewer has tested changes by following the provided instructions?
Changes appear not to be breaking changes?
Appropriate automated tests included?
Code style and in-line documentation are appropriate?

…tItem()`" This reverts commit 4f8403a.

… and `setItem()`"" This reverts commit 0de6640.

…-tests

codecov · 2024-01-18T19:21:23Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (43ae3cf) 55.89% compared to head (ab01db9) 55.66%.

❗ Current head ab01db9 differs from pull request most recent head f235d50. Consider uploading reports for the commit f235d50 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7387      +/-   ##
==========================================
- Coverage   55.89%   55.66%   -0.23%     
==========================================
  Files         659      659              
  Lines       26277    26277              
  Branches     2549     2549              
==========================================
- Hits        14687    14628      -59     
- Misses      10882    10940      +58     
- Partials      708      709       +1

Flag	Coverage Δ
e2e-full	`41.25% <ø> (+0.17%)`	⬆️
e2e-stable	`58.54% <ø> (-0.53%)`	⬇️
unit	`48.90% <0.00%> (-0.04%)`	⬇️

Files	Coverage Δ
src/plugins/imagery/components/ImageryView.vue	`40.19% <ø> (ø)`
src/ui/components/ProgressBar.vue	`100.00% <ø> (ø)`
src/ui/layout/AppLayout.vue	`20.40% <0.00%> (ø)`

... and 21 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ae3cf...f235d50. Read the comment docs.

…-tests

unlikelyzero · 2024-01-22T19:13:56Z

All that's left is role=progressbar

ozyx

Awesome ! I just had one review comment from a pending review, and this needs a good linting. Should be g2g after that

e2e/appActions.js

ozyx · 2024-01-23T03:34:34Z

src/ui/components/ProgressBar.vue

@@ -25,6 +25,10 @@
      class="c-progress-bar__bar"
      :class="{ '--indeterminate': !progressPerc }"
      :style="styleBarWidth"
+      role="progressbar"
+      :aria-valuenow="progressPerc"


unlikelyzero · 2024-01-23T05:26:35Z

e2e/tests/functional/plugins/inspectorDataVisualization/numericData.e2e.spec.js

@@ -36,7 +36,7 @@ test.describe('Testing numeric data with inspector data visualization (i.e., dat
    await page.goto('./', { waitUntil: 'domcontentloaded' });
  });

-  test('Can click on telemetry and see data in inspector', async ({ page, context }) => {
+  test('Can click on telemetry and see data in inspector @2p', async ({ page, context }) => {


driveby for @scottbell

unlikelyzero · 2024-01-23T05:27:00Z

e2e/tests/functional/plugins/notebook/notebookSnapshotImage.e2e.spec.js

+
+const NOTEBOOK_NAME = 'Notebook';
+
+test.describe('Snapshot image tests', () => {


broke this out into its own suite for speed

doesn't it parallelize by file and not suite? or has that changed

it's by file. I broke up the image and regular snapshot suites

unlikelyzero · 2024-01-23T05:27:23Z

e2e/tests/functional/plugins/notebook/notebookSnapshots.e2e.spec.js

@@ -91,22 +85,13 @@ test.describe('Snapshot Container tests', () => {

    await page.getByLabel('Take a Notebook Snapshot').click();
    await page.getByRole('menuitem', { name: 'Save to Notebook Snapshots' }).click();
-    await page.getByRole('button', { name: 'Show' }).click();
+    await page.getByLabel('Show Snapshots').click();


locator fixes

unlikelyzero · 2024-01-23T05:27:55Z

e2e/tests/visual-a11y/components/header.visual.spec.js

@@ -50,6 +50,17 @@ test.describe('Visual - Header @a11y', () => {
      scope: header
    });
  });
+
+  test('show snapshot button', async ({ page, theme }) => {


realized we were missing this one

unlikelyzero · 2024-01-23T05:28:29Z

e2e/tests/visual-a11y/components/header.visual.spec.js

+    await percySnapshot(page, `Notebook Snapshot Show button (theme: '${theme}')`, {
+      scope: header
+    });
+    await expect(await page.getByLabel('Show Snapshots')).toBeVisible();


need to wait for button to appear in header

ozyx · 2024-01-23T05:31:09Z

e2e/tests/functional/plugins/importAndExportAsJSON/exportAsJson.e2e.spec.js

+  let folder;
+  test.beforeEach(async ({ page }) => {
+    // Go to baseURL
+    await page.goto('./', { waitUntil: 'networkidle' });


networkidle?

ozyx and others added 25 commits January 17, 2024 11:15

refactor(ExportAsJSONAction): use private methods

68edf79

refactor: remove unnecessary webpack alias

b07a73e

refactor: lint

a0b71f4

fix: tests for ExportAsJSONAction

95ac152

test: stabilize InspectorStylesSpec tests

44fac67

docs: fix jsdocs

81b6b97

chore: remove dead / redundant code

9a1437a

refactor(LocalStorageObjectProvider): use getItem() and setItem()

4f8403a

refactor(ExportAsJSONAction): use Promise.all where applicable

7378351

refactor(MenuAPI): one-liner

201deea

feat: add percentage ProgressBar to ExportAsJSONAction

9f85a0b

fix(ProgressBar.vue): v-if conditionals

975ef25

test(fix): update mockLocalStorage

3a0c975

test: fix locators

24b80e3

test: remove unneeded awaits

b88c849

fix: example imagery urls (moved after NASA wordpress migration)

d5b02b0

Revert "refactor(LocalStorageObjectProvider): use getItem() and `se…

0de6640

…tItem()`" This reverts commit 4f8403a.

test(e2e): fix logPlot test

cb3d408

Revert "Revert "refactor(LocalStorageObjectProvider): use getItem()…

ef64b0d

… and `setItem()`"" This reverts commit 0de6640.

test(e2e): remove waitForNavigations

b47ceff

driveby and fixes

fecd1ae

aria improvement

590e2ea

getting tests back oline

31bb25d

more tests

c05e22d

Merge branch 'master' of https://github.com/nasa/openmct into mct7367…

84caca1

…-tests

add last test

4901bf7

ozyx added the type:maintenance tests, chores, or project maintenance label Jan 18, 2024

ozyx self-requested a review January 18, 2024 19:55

Merge branch 'master' of https://github.com/nasa/openmct into mct7367…

0e9b667

…-tests

Add a11y

c26f124

unlikelyzero added this to the Target:4.0.0 milestone Jan 23, 2024

ozyx approved these changes Jan 23, 2024

View reviewed changes

unlikelyzero added 8 commits January 22, 2024 20:01

lint

496b6c6

lint

615face

driveby

406a94d

review comments

7a4ee18

driveby rename

16dd00c

fix selectors and break up test suites

94b690a

add test for snapshot in header

af95399

last lint fixes

ab01db9

unlikelyzero commented Jan 23, 2024

View reviewed changes

unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 23, 2024

ozyx reviewed Jan 23, 2024

View reviewed changes

github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 23, 2024

unlikelyzero added 2 commits January 22, 2024 21:39

stable

f235d50

comment

84597e8

unlikelyzero merged commit 4cf6306 into master Jan 23, 2024
4 of 11 checks passed

unlikelyzero deleted the mct7367-tests branch January 23, 2024 05:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mct7367-tests #7387

Mct7367-tests #7387

unlikelyzero commented Jan 18, 2024 •

edited by ozyx

Loading

codecov bot commented Jan 18, 2024 •

edited

Loading

unlikelyzero commented Jan 22, 2024

ozyx left a comment

ozyx Jan 23, 2024

unlikelyzero Jan 23, 2024

unlikelyzero Jan 23, 2024

ozyx Jan 23, 2024

unlikelyzero Jan 23, 2024

unlikelyzero Jan 23, 2024

unlikelyzero Jan 23, 2024

unlikelyzero Jan 23, 2024

ozyx Jan 23, 2024


		const NOTEBOOK_NAME = 'Notebook';

		test.describe('Snapshot image tests', () => {

Mct7367-tests #7387

Mct7367-tests #7387

Conversation

unlikelyzero commented Jan 18, 2024 • edited by ozyx Loading

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

codecov bot commented Jan 18, 2024 • edited Loading

Codecov Report

unlikelyzero commented Jan 22, 2024

ozyx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unlikelyzero commented Jan 18, 2024 •

edited by ozyx

Loading

codecov bot commented Jan 18, 2024 •

edited

Loading