fix: cleanup from #7029 #7328
Merged
fix: cleanup from #7029 #7328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Current Playwright Test Results Summary✅ 166 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/28/2023 06:34:02pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use independent time conductor to change time
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 46 runsfailed over last 7 days |
4.35% (2)2 / 46 runsflaked over last 7 days |
📄 functional/plugins/tabs/tabs.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Tabs View Renders tabbed elements
Retry 1 • Initial Attempt |
10.81% (4)4 / 37 runsfailed over last 7 days |
24.32% (9)9 / 37 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 39 runsfailed over last 7 days |
56.41% (22)22 / 39 runsflaked over last 7 days |
📄 functional/plugins/conditionSet/conditionSet.e2e.spec.js • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Condition Set CRUD Operations on @localStorage Condition set object properties persist in main view and inspector @localStorage
Retry 1 • Initial Attempt |
5.41% (2)2 / 37 runsfailed over last 7 days |
2.70% (1)1 / 37 runflaked over last 7 days |
|
Condition Set CRUD Operations on @localStorage condition set object can be modified on @localStorage
Retry 1 • Initial Attempt |
0% (0)0 / 34 runsfailed over last 7 days |
2.94% (1)1 / 34 runflaked over last 7 days |
|
Condition Set CRUD Operations on @localStorage condition set object can be deleted by Search Tree Actions menu on @localStorage
Retry 1 • Initial Attempt |
-3.03% (-1)-1 / 33 runsfailed over last 7 days |
3.03% (1)1 / 33 runflaked over last 7 days |
📄 functional/plugins/timeConductor/timeConductor.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time conductor input fields real-time mode preserve offsets and url params when switching between fixed and real-time mode
Retry 1 • Initial Attempt |
0% (0)0 / 34 runsfailed over last 7 days |
2.94% (1)1 / 34 runflaked over last 7 days |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7328 +/- ##
==========================================
- Coverage 55.69% 55.65% -0.05%
==========================================
Files 656 656
Lines 26203 26194 -9
Branches 2546 2546
==========================================
- Hits 14594 14577 -17
+ Misses 10911 10909 -2
- Partials 698 708 +10
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ozyx
suggested changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Cleanup PR from #7029 to convert a few more modules to ESM, and to stop using
require.All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist