-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer intersection monitoring until needed to prevent race conditions #7278
Conversation
Current Playwright Test Results Summary✅ 15 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/15/2023 08:34:24am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 4dbb574 Started: 12/15/2023 08:32:41am UTC Current Playwright Test Results Summary✅ 165 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/15/2023 08:34:24am UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 54 runsfailed over last 7 days |
42.59% (23)23 / 54 runsflaked over last 7 days |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7278 +/- ##
==========================================
- Coverage 55.96% 55.91% -0.05%
==========================================
Files 655 655
Lines 26316 26324 +8
Branches 2543 2544 +1
==========================================
- Hits 14728 14720 -8
- Misses 10881 10891 +10
- Partials 707 713 +6
*This pull request uses carry forward flags. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Before: Before.movAfter: After.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@akhenry please let me know if there's anything else we need to test here |
Merging for the interim, but can revert if we need. |
Closes #7277
Describe your changes:
renderWhenVisible
is called once. This prevents every View needing to subscribe to intersection events, and prevents a race condition where the view isn't quite built yet.draw
once. Prevents similar race condition as above.All Submissions:
Author Checklist
Reviewer Checklist