Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package.json): fix warning during npm publish #7253

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Nov 21, 2023

N/A

Describe your changes:

Fixes warning about url during npm publish. npm automatically updates the repository url to this before publish. This is the result of running npm pkg fix to resolve the warning.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Nov 21, 2023
Copy link

deploysentinel bot commented Nov 21, 2023

Current Playwright Test Results Summary

✅ 162 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/01/2023 05:43:43pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: e46bc09

Started: 12/01/2023 05:35:47pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
0% (0) 0 / 37 runs
failed over last 7 days
21.62% (8) 8 / 37 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
5.08% (3) 3 / 59 runs
failed over last 7 days
47.46% (28) 28 / 59 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1Initial Attempt
0% (0) 0 / 37 runs
failed over last 7 days
21.62% (8) 8 / 37 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
2.70% (1) 1 / 37 run
failed over last 7 days
59.46% (22) 22 / 37 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/01/2023 05:43:43pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: e46bc09

Started: 12/01/2023 05:35:58pm UTC

View Detailed Build Results


Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #7253 (d021243) into master (41bee31) will increase coverage by 0.31%.
The diff coverage is n/a.

❗ Current head d021243 differs from pull request most recent head e46bc09. Consider uploading reports for the commit e46bc09 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7253      +/-   ##
==========================================
+ Coverage   55.72%   56.04%   +0.31%     
==========================================
  Files         654      654              
  Lines       26229    26228       -1     
  Branches     2528     2528              
==========================================
+ Hits        14616    14699      +83     
+ Misses      10914    10829      -85     
- Partials      699      700       +1     
Flag Coverage Δ *Carryforward flag
e2e-full 41.88% <ø> (ø) Carriedforward from 28bfc90
e2e-stable 58.32% <ø> (-0.04%) ⬇️
unit 49.34% <ø> (+0.49%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41bee31...e46bc09. Read the comment docs.

@unlikelyzero unlikelyzero added this to the Target:3.3.0 milestone Nov 22, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 1, 2023
@ozyx ozyx enabled auto-merge (squash) December 1, 2023 17:33
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 1, 2023
@ozyx ozyx merged commit 2dc1388 into master Dec 1, 2023
11 of 13 checks passed
@ozyx ozyx deleted the ozyx-patch-1 branch December 1, 2023 17:44
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants