-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce bundle size #7246
Reduce bundle size #7246
Conversation
Current Playwright Test Results Summary✅ 15 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/20/2023 05:52:15pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 0fc7ad4 Started: 12/20/2023 05:48:07pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
CouchDB Status Indicator with mocked responses @couchdb Shows red if not connected
Retry 1 • Initial Attempt |
0% (0)0 / 38 runsfailed over last 7 days |
13.16% (5)5 / 38 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 166 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 12/20/2023 05:52:15pm UTC)
⚠️ Flakes
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 2 • Retry 1 • Initial Attempt |
2.33% (2)2 / 86 runsfailed over last 7 days |
24.42% (21)21 / 86 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
2.25% (2)2 / 89 runsfailed over last 7 days |
39.33% (35)35 / 89 runsflaked over last 7 days |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7246 +/- ##
==========================================
- Coverage 56.03% 55.97% -0.07%
==========================================
Files 658 658
Lines 26364 26361 -3
Branches 2546 2546
==========================================
- Hits 14774 14755 -19
- Misses 10889 10896 +7
- Partials 701 710 +9
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
👍 for issue name and reducing the bundle size |
0cbfac3
to
08973a2
Compare
068189c
to
3f66745
Compare
@ozyx what's the best way to test this? |
Something like:
I thought we could compress even smaller but I think best we can do is a few MB, without removing e2e or source files/maps (which I don't think we want to do). As a whole our package size has been on a downward trend since 1.8 which is good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changing TelemetryValueFormatter
to an es6 class would be cool, but not necessary for this PR.
File size was reduced:
-rw-r--r--@ 1 scott staff 5.4M Dec 19 12:11 openmct-3.3.0-honey.tgz
-rw-r--r--@ 1 scott staff 5.9M Dec 19 12:07 openmct-3.3.0-master.tgz
nice job! Smoke test of functionality went well.
Closes #7286
Describe your changes:
Brings unpacked bundle size from 26.3MB - 24.3MB
All Submissions:
Author Checklist
Reviewer Checklist