Make Tabs eager loading configurable but default to false

[davetsay]

Closes #7198

Describe your changes:

• make tabs eager load configurable
• default is eager load false changed from eager load true
• change dropdown to toggle

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

• Changes address original issue?
• Tests included and/or updated with changes?
• Has this been smoke tested?
• Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
• Have you associated a milestone with this PR? Note: leave blank if unsure.
• Is this a breaking change to be called out in the release notes?
• Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

• Changes appear to address issue?
• Reviewer has tested changes by following the provided instructions?
• Changes appear not to be breaking changes?
• Appropriate automated tests included?
• Code style and in-line documentation are appropriate?

[deploysentinel]

Current Playwright Test Results Summary

✅ 15 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/11/2024 08:10:22am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 7b9a365

Started: 01/11/2024 08:05:46am UTC

View Detailed Build Results

---

Current Playwright Test Results Summary

✅ 175 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/11/2024 08:10:22am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 7b9a365

Started: 01/11/2024 08:04:56am UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh Retry 1 • Initial Attempt	0% (0) 0 / 76 runs failed over last 7 days	28.95% (22) 22 / 76 runs flaked over last 7 days

---

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit Retry 1 • Initial Attempt	4.11% (3) 3 / 73 runs failed over last 7 days	36.99% (27) 27 / 73 runs flaked over last 7 days

---

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds Retry 1 • Initial Attempt	6.15% (4) 4 / 65 runs failed over last 7 days	18.46% (12) 12 / 65 runs flaked over last 7 days

---

View Detailed Build Results

---

[unlikelyzero]

@davetsay let's sync with @scottbell next week to talk about this change

[unlikelyzero]

This needs a test in Open MCT YAMCS and should be called out in the release notes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (735c823) 55.82% compared to head (aaf1e99) 55.83%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7199      +/-   ##
==========================================
+ Coverage   55.82%   55.83%   +0.01%     
==========================================
  Files         666      666              
  Lines       26513    26514       +1     
  Branches     2585     2585              
==========================================
+ Hits        14800    14805       +5     
+ Misses      10998    10994       -4     
  Partials      715      715              

Flag	Coverage Δ		*Carryforward flag
e2e-full	41.81% <ø> (+<0.01%)	⬆️	Carriedforward from 2ed3994
e2e-stable	59.80% <100.00%> (+0.01%)	⬆️
unit	48.88% <100.00%> (+<0.01%)	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
src/plugins/tabs/plugin.js	100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735c823...aaf1e99. Read the comment docs.

[davetsay]

This needs a test in Open MCT YAMCS and should be called out in the release notes

@unlikelyzero ,
It has a unit test to test the only change, which is what type of tab the form defaults to. Why would this need a test in Open MCT YAMCS?

It does not change the behavior of the tabs object what so ever. Why is it a breaking change?

[scottbell]

Good work @davetsay! It does what it says on the tin. Here's before:

Here's after without setting the options installing the tab plugin (defaulting eager loading to false):

And here's with the option in the plugin with eagerLoad set to true:

@davetsay I didn't see any testing notes on the ticket, so I put together a draft. Let me know if it looks good to you.