-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static limit values to LAD tables #7193
Conversation
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/08/2023 05:56:27pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 1f6f15a Started: 11/08/2023 05:54:44pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt |
0% (0)0 / 48 runsfailed over last 7 days |
12.50% (6)6 / 48 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 153 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 11/08/2023 05:56:27pm UTC)
⚠️ Flakes
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
1.35% (2)2 / 148 runsfailed over last 7 days |
50% (74)74 / 148 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
0% (0)0 / 150 runsfailed over last 7 days |
68.67% (103)103 / 150 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #7193 +/- ##
==========================================
+ Coverage 55.98% 56.08% +0.09%
==========================================
Files 652 652
Lines 26187 26178 -9
Branches 2524 2525 +1
==========================================
+ Hits 14660 14681 +21
+ Misses 10829 10797 -32
- Partials 698 700 +2
*This pull request uses carry forward flags. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Just some minor suggestions regarding some e2e locators. Let's also sync tomorrow and get this feature-tested against VIPER
Co-authored-by: Jesse Mazzella <[email protected]>
Co-authored-by: Jesse Mazzella <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #5051
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist