Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static limit values to LAD tables #7193

Merged
merged 18 commits into from
Nov 8, 2023

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Oct 31, 2023

Closes #5051

Describe your changes:

  • Added limits to table columns
  • Simplify how table headers are calculated for inspector. Allow limits to be removed

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@scottbell scottbell linked an issue Oct 31, 2023 that may be closed by this pull request
@scottbell scottbell changed the title 5051 add static limit values to lad tables Add static limit values to LAD tables Oct 31, 2023
@deploysentinel
Copy link

deploysentinel bot commented Oct 31, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/08/2023 05:56:27pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 1f6f15a

Started: 11/08/2023 05:54:44pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
0% (0) 0 / 48 runs
failed over last 7 days
12.50% (6) 6 / 48 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 153 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/08/2023 05:56:27pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 1f6f15a

Started: 11/07/2023 06:31:19pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
1.35% (2) 2 / 148 runs
failed over last 7 days
50% (74) 74 / 148 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
0% (0) 0 / 150 runs
failed over last 7 days
68.67% (103) 103 / 150 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #7193 (1f6f15a) into master (09b7873) will increase coverage by 0.09%.
The diff coverage is 47.36%.

@@            Coverage Diff             @@
##           master    #7193      +/-   ##
==========================================
+ Coverage   55.98%   56.08%   +0.09%     
==========================================
  Files         652      652              
  Lines       26187    26178       -9     
  Branches     2524     2525       +1     
==========================================
+ Hits        14660    14681      +21     
+ Misses      10829    10797      -32     
- Partials      698      700       +2     
Flag Coverage Δ *Carryforward flag
e2e-full 41.82% <ø> (ø) Carriedforward from 09b7873
e2e-stable 58.01% <ø> (+0.11%) ⬆️
unit 49.49% <47.36%> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/plugins/LADTable/components/LadRow.vue 53.06% <81.81%> (-0.35%) ⬇️
src/plugins/LADTable/components/LadTable.vue 43.66% <69.23%> (-1.34%) ⬇️
...gins/LADTable/components/LadTableConfiguration.vue 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09b7873...1f6f15a. Read the comment docs.

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 31, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 31, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 31, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 31, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 1, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 1, 2023
@ozyx ozyx added the type:feature Feature. Required intentional design label Nov 1, 2023
@ozyx ozyx added this to the Target:3.2.0 milestone Nov 1, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just some minor suggestions regarding some e2e locators. Let's also sync tomorrow and get this feature-tested against VIPER

e2e/tests/functional/plugins/lad/lad.e2e.spec.js Outdated Show resolved Hide resolved
e2e/tests/functional/plugins/lad/lad.e2e.spec.js Outdated Show resolved Hide resolved
e2e/tests/functional/plugins/lad/lad.e2e.spec.js Outdated Show resolved Hide resolved
@scottbell scottbell requested a review from ozyx November 2, 2023 12:38
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 2, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 2, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 3, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 3, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 6, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 6, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 7, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 7, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 7, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 7, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottbell scottbell enabled auto-merge (squash) November 8, 2023 17:51
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 8, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 8, 2023
@scottbell scottbell merged commit 51eb2a4 into master Nov 8, 2023
15 checks passed
@scottbell scottbell deleted the 5051-add-static-limit-values-to-lad-tables branch November 8, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature. Required intentional design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add static limit values to LAD tables
2 participants