Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Staleness] Fix issue with object view staleness styles not being reset on clock change #7122

Merged
merged 2 commits into from
Oct 6, 2023
Merged

[Staleness] Fix issue with object view staleness styles not being reset on clock change #7122

merged 2 commits into from
Oct 6, 2023

Conversation

khalidadil
Copy link
Contributor

Closes #6339

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@khalidadil khalidadil linked an issue Oct 6, 2023 that may be closed by this pull request
[Staleness] Switching between clock modes incorrectly persists the current staleness state #6339
Closed
7 tasks
@deploysentinel
Copy link

deploysentinel bot commented Oct 6, 2023 •
edited
Loading

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/06/2023 09:50:48pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: c9ad368

Started: 10/06/2023 09:43:34pm UTC

View Detailed Build Results

Current Playwright Test Results Summary

✅ 141 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/06/2023 09:50:48pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: c9ad368

Started: 10/06/2023 09:43:00pm UTC

⚠️ Flakes

📄   functional/plugins/timeConductor/timeConductor.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time conductor input fields real-time mode preserve offsets and url params when switching between fixed and real-time mode
Retry 1 • Initial Attempt
0% (0) 0 / 95 runs
failed over last 7 days
2.11% (2) 2 / 95 runs
flaked over last 7 days
📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt
4% (4) 4 / 100 runs
failed over last 7 days
29% (29) 29 / 100 runs
flaked over last 7 days

View Detailed Build Results

jvigliotta
jvigliotta approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jvigliotta jvigliotta merged commit 6b32c63 into master Oct 6, 2023
10 checks passed
@jvigliotta jvigliotta deleted the bugfix/issue-6339-object-view-fix branch October 6, 2023 22:26
@ozyx ozyx added this to the Target:3.1.0 milestone Oct 6, 2023
khalidadil added a commit that referenced this pull request Oct 6, 2023
@khalidadil
[Staleness] Fix issue with object view staleness styles not being res…
95b3db2 
…et on clock change (#7122)

Add logic to un/re-subscribe when clock changes to object view
jvigliotta pushed a commit that referenced this pull request Oct 6, 2023
@khalidadil
cherry-pick(#7122): [Staleness] Fix issue with object view staleness …
e43ddf6 
…styles not being res… (#7123)

[Staleness] Fix issue with object view staleness styles not being reset on clock change (#7122)

Add logic to un/re-subscribe when clock changes to object view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvigliotta jvigliotta jvigliotta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Target:3.1.0
Development

Successfully merging this pull request may close these issues.

[Staleness] Switching between clock modes incorrectly persists the current staleness state
3 participants
@khalidadil @jvigliotta @ozyx