-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visible toolbar overflow #7037
Conversation
Current Playwright Test Results Summary✅ 161 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/16/2023 08:13:11pm UTC)
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 58 runsfailed over last 7 days |
43.10% (25)25 / 58 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 58 runsfailed over last 7 days |
58.62% (34)34 / 58 runsflaked over last 7 days |
📄 functional/plugins/gauge/gauge.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Gauge Gauge does not display NaN when data not available
Retry 1 • Initial Attempt |
0% (0)0 / 6 runsfailed over last 7 days |
16.67% (1)1 / 6 runflaked over last 7 days |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7037 +/- ##
==========================================
- Coverage 55.53% 55.20% -0.34%
==========================================
Files 672 672
Lines 26961 26962 +1
Branches 2620 2620
==========================================
- Hits 14974 14884 -90
- Misses 11269 11360 +91
Partials 718 718
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs test
@unlikelyzero How do I create a test for this? Is this critical now for a purely visual element that we're trying to get under the limbo bar? |
Created ticket to address needing visual test. #7178 |
9df1a7d
to
d6fc6b7
Compare
visual test added |
Closes #7036.
overflow: hidden
to __pane-main > .l-pane__contents.Closes
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist