Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visible toolbar overflow #7037

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Fix visible toolbar overflow #7037

merged 4 commits into from
Feb 29, 2024

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Sep 5, 2023

Closes #7036.

  • CSS fix to prevent toolbar overrun of main view area.
  • Added overflow: hidden to __pane-main > .l-pane__contents.
  • Added visual test for toolbar overflow

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Sep 5, 2023

Current Playwright Test Results Summary

✅ 161 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/16/2023 08:13:11pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 71d3870

Started: 11/16/2023 08:05:58pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 58 runs
failed over last 7 days
43.10% (25) 25 / 58 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 58 runs
failed over last 7 days
58.62% (34) 34 / 58 runs
flaked over last 7 days

📄   functional/plugins/gauge/gauge.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Gauge Gauge does not display NaN when data not available
Retry 1Initial Attempt
0% (0) 0 / 6 runs
failed over last 7 days
16.67% (1) 1 / 6 run
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.20%. Comparing base (7d25c96) to head (d6fc6b7).

❗ Current head d6fc6b7 differs from pull request most recent head 7a5897e. Consider uploading reports for the commit 7a5897e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7037      +/-   ##
==========================================
- Coverage   55.53%   55.20%   -0.34%     
==========================================
  Files         672      672              
  Lines       26961    26962       +1     
  Branches     2620     2620              
==========================================
- Hits        14974    14884      -90     
- Misses      11269    11360      +91     
  Partials      718      718              
Flag Coverage Δ
e2e-full 21.69% <ø> (-19.83%) ⬇️
e2e-stable 59.54% <ø> (-0.06%) ⬇️
unit 48.49% <100.00%> (-0.03%) ⬇️
Files Coverage Δ
src/ui/layout/PaneContainer.vue 48.83% <100.00%> (+0.60%) ⬆️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d25c96...7a5897e. Read the comment docs.

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davetsay davetsay enabled auto-merge (squash) September 6, 2023 19:39
@unlikelyzero unlikelyzero self-requested a review September 7, 2023 19:19
Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs test

@charlesh88
Copy link
Contributor Author

@unlikelyzero How do I create a test for this? Is this critical now for a purely visual element that we're trying to get under the limbo bar?

@davetsay davetsay added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 26, 2023
@davetsay
Copy link
Contributor

needs test

Created ticket to address needing visual test. #7178

@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 26, 2023
@davetsay davetsay added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 26, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 26, 2023
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Jan 30, 2024
charlesh88 and others added 3 commits February 27, 2024 09:50
@ozyx ozyx disabled auto-merge February 27, 2024 18:51
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 27, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 27, 2024
@ozyx
Copy link
Contributor

ozyx commented Feb 27, 2024

needs test

visual test added

@unlikelyzero unlikelyzero merged commit e449fd0 into master Feb 29, 2024
11 of 12 checks passed
@unlikelyzero unlikelyzero deleted the fix-toolbar-7036 branch February 29, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Layout editing tools overlaps inspector
4 participants