Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining vue-compat warnings #6966

Merged
merged 34 commits into from
Oct 10, 2023
Merged

Fix remaining vue-compat warnings #6966

merged 34 commits into from
Oct 10, 2023

Conversation

depperm
Copy link
Contributor

@depperm depperm commented Aug 19, 2023

Closes #7124

Describe your changes:

  • Fix remaining vue-compat warnings by:
    • add emits in declaration
    • file components are PascalCase and MultiWord
    • added eventbus for two places use $once and $on, (might be a better way to handle this)
    • remove use of $listeners as it is deprecated
    • remove deprecated Vue import in favor of importing individual methods

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added the source:community Community contribution or request label Aug 20, 2023
@ozyx
Copy link
Contributor

ozyx commented Aug 22, 2023

@depperm This is awesome! This will help in our migration to Vue 3 proper. Before we can merge, we will need the tests to be passing. It looks like the e2e tests are failing due to file path changes or something similar. Could you please look into and fix the failing tests on #6955 ? Please let us know if you have any questions about it, we are happy to help!

@depperm
Copy link
Contributor Author

depperm commented Aug 23, 2023

@ozyx Looking at the tests that are failing:

...
ERROR in ./src/ui/layout/search/GrandSearch.vue?vue&type=script&lang=js (./node_modules/vue-loader/dist/index.js??ruleSet[0]!./src/ui/layout/search/GrandSearch.vue?vue&type=script&lang=js) 2:0-49
Module not found: Error: Can't resolve '../../components/Search.vue' in '/root/project/src/ui/layout/search'

ERROR in ./src/plugins/LADTable/LADTableConfigurationViewProvider.js 23:0-84
Module not found: Error: Can't resolve './components/LadTableConfiguration.vue' in '/root/project/src/plugins/LADTable'

ERROR in ./src/plugins/LADTable/LADTableView.js 23:0-49
Module not found: Error: Can't resolve './components/LadTable.vue' in '/root/project/src/plugins/LADTable'

ERROR in ./src/plugins/clearData/plugin.js 23:0-73
Module not found: Error: Can't resolve './components/GlobalClearIndicator.vue' in '/root/project/src/plugins/clearData'

ERROR in ./src/plugins/flexibleLayout/flexibleLayoutViewProvider.js 24:0-70
Module not found: Error: Can't resolve './components/FlexibleLayout.vue' in '/root/project/src/plugins/flexibleLayout'

ERROR in ./src/plugins/tabs/tabs.js 24:0-50
Module not found: Error: Can't resolve './components/Tabs.vue' in '/root/project/src/plugins/tabs'

ERROR in ./src/plugins/telemetryTable/TelemetryTableView.js 1:0-52
Module not found: Error: Can't resolve './components/Table.vue' in '/root/project/src/plugins/telemetryTable'

it doesn't look like the file names are updating. I'm not sure how to fix this. Looking at the last example it says it can't resolve Table.vue but I've updated the code to TableComponent.vue:
file: https://github.com/nasa/openmct/pull/6966/files#diff-09db24f148ad1c2ff6dc49bf89aa41d0cb53de9d8062217a99ac75dd77d35440

I can't find any reference to Table.vue

@depperm
Copy link
Contributor Author

depperm commented Aug 24, 2023

#6988 might resolve

@ozyx
Copy link
Contributor

ozyx commented Sep 14, 2023

@depperm could you fix the conflicts here please? Thanks!

@deploysentinel
Copy link

deploysentinel bot commented Sep 25, 2023

Current Playwright Test Results Summary

✅ 141 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/09/2023 07:07:10pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 6374679

Started: 10/09/2023 07:00:54pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 87 runs
failed over last 7 days
33.33% (29) 29 / 87 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
1.47% (2) 2 / 136 runs
failed over last 7 days
58.09% (79) 79 / 136 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
14.29% (15) 15 / 105 runs
failed over last 7 days
48.57% (51) 51 / 105 runs
flaked over last 7 days

View Detailed Build Results


@ozyx ozyx self-requested a review October 6, 2023 18:54
@ozyx ozyx added this to the Target:3.2.0 milestone Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #6966 (6374679) into master (6b32c63) will decrease coverage by 0.12%.
The diff coverage is 38.92%.

@@            Coverage Diff             @@
##           master    #6966      +/-   ##
==========================================
- Coverage   55.88%   55.76%   -0.12%     
==========================================
  Files         650      651       +1     
  Lines       26106    26114       +8     
  Branches     2521     2521              
==========================================
- Hits        14589    14563      -26     
- Misses      10823    10847      +24     
- Partials      694      704      +10     
Flag Coverage Δ *Carryforward flag
e2e-full 41.88% <ø> (+<0.01%) ⬆️ Carriedforward from ae17cb0
e2e-stable 57.28% <100.00%> (-0.08%) ⬇️
unit 49.32% <37.58%> (-0.11%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/MCT.js 97.32% <ø> (ø)
src/api/forms/FormController.js 96.00% <ø> (ø)
src/api/forms/FormsAPI.js 94.87% <ø> (ø)
src/api/forms/components/FormRow.vue 73.52% <100.00%> (ø)
...ms/components/controls/ClockDisplayFormatField.vue 0.00% <ø> (ø)
...rc/api/forms/components/controls/DatetimeField.vue 2.85% <ø> (ø)
src/api/forms/components/controls/FileInput.vue 0.00% <ø> (ø)
src/api/forms/components/controls/LocatorField.vue 0.00% <ø> (ø)
src/api/forms/components/controls/NumberField.vue 0.00% <ø> (ø)
src/api/forms/components/controls/SelectField.vue 0.00% <ø> (ø)
... and 165 more

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b32c63...6374679. Read the comment docs.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 9, 2023
@ozyx ozyx changed the title Mct4398 Fix remaining vue-compat warnings Oct 9, 2023
@ozyx
Copy link
Contributor

ozyx commented Oct 9, 2023

@depperm Thanks for doing the heavy lifting on this one! I'm going to have another member of the team give this a re-review before we merge because it's so large, but this PR gets us to the point where we will be able to upgrade to Vue 3 proper. That's huge! Well done.

@ozyx ozyx requested a review from scottbell October 9, 2023 19:06
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Oct 9, 2023
Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some cursory testing of Open MCT, particularly with plots and configurations, and it all looked good! On inspection, code looks straightforwardly changed too.

@ozyx ozyx merged commit 97b2ebc into nasa:master Oct 10, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix remaining vue-compat warnings
3 participants