-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining vue-compat
warnings
#6966
Conversation
@depperm This is awesome! This will help in our migration to Vue 3 proper. Before we can merge, we will need the tests to be passing. It looks like the e2e tests are failing due to file path changes or something similar. Could you please look into and fix the failing tests on #6955 ? Please let us know if you have any questions about it, we are happy to help! |
@ozyx Looking at the tests that are failing:
it doesn't look like the file names are updating. I'm not sure how to fix this. Looking at the last example it says it can't resolve Table.vue but I've updated the code to TableComponent.vue: I can't find any reference to Table.vue |
#6988 might resolve |
@depperm could you fix the conflicts here please? Thanks! |
Current Playwright Test Results Summary✅ 141 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/09/2023 07:07:10pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 87 runsfailed over last 7 days |
33.33% (29)29 / 87 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
1.47% (2)2 / 136 runsfailed over last 7 days |
58.09% (79)79 / 136 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
14.29% (15)15 / 105 runsfailed over last 7 days |
48.57% (51)51 / 105 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6966 +/- ##
==========================================
- Coverage 55.88% 55.76% -0.12%
==========================================
Files 650 651 +1
Lines 26106 26114 +8
Branches 2521 2521
==========================================
- Hits 14589 14563 -26
- Misses 10823 10847 +24
- Partials 694 704 +10
*This pull request uses carry forward flags. Click here to find out more.
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@depperm Thanks for doing the heavy lifting on this one! I'm going to have another member of the team give this a re-review before we merge because it's so large, but this PR gets us to the point where we will be able to upgrade to Vue 3 proper. That's huge! Well done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some cursory testing of Open MCT, particularly with plots and configurations, and it all looked good! On inspection, code looks straightforwardly changed too.
Closes #7124
Describe your changes:
vue-compat
warnings by:$once
and$on
, (might be a better way to handle this)$listeners
as it is deprecatedVue
import in favor of importing individual methodsAll Submissions:
Author Checklist
Reviewer Checklist