Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strategy latest and timeContext to auto flow tabular and gauge views #6960

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Aug 18, 2023

Closes VIPEROMCT-393

Describe your changes:

Autoflow tabular and gauge views were missing timeContexts (which enable some telemetry providers to optimize requests)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@shefalijoshi shefalijoshi added this to the Target:3.0.1 milestone Aug 18, 2023
@deploysentinel
Copy link

deploysentinel bot commented Aug 18, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/21/2023 09:09:21pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 69fec89

Started: 08/21/2023 09:03:33pm UTC

⚠️ Flakes

📄   functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1Initial Attempt
15% (9) 9 / 60 runs
failed over last 7 days
23.33% (14) 14 / 60 runs
flaked over last 7 days

📄   functional/couchdb.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
CouchDB Status Indicator with mocked responses @couchdb Shows unknown if it receives an unexpected response code
Retry 1Initial Attempt
0% (0) 0 / 60 runs
failed over last 7 days
6.67% (4) 4 / 60 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/21/2023 09:09:21pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 69fec89

Started: 08/21/2023 09:02:34pm UTC

⚠️ Flakes

📄   functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Plot Tagging Tags work with Overlay Plots
Retry 2Retry 1Initial Attempt
10.49% (17) 17 / 162 runs
failed over last 7 days
29.01% (47) 47 / 162 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 194 runs
failed over last 7 days
53.09% (103) 103 / 194 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 162 runs
failed over last 7 days
42.59% (69) 69 / 162 runs
flaked over last 7 days

View Detailed Build Results


@shefalijoshi shefalijoshi enabled auto-merge (squash) August 21, 2023 17:52
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #6960 (d68fa0a) into master (9ece4e5) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head d68fa0a differs from pull request most recent head 69fec89. Consider uploading reports for the commit 69fec89 to get more accurate results

@@            Coverage Diff             @@
##           master    #6960      +/-   ##
==========================================
+ Coverage   48.29%   48.33%   +0.03%     
==========================================
  Files         643      643              
  Lines       25719    25721       +2     
  Branches     2512     2512              
==========================================
+ Hits        12422    12433      +11     
+ Misses      12817    12807      -10     
- Partials      480      481       +1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.00% <ø> (+<0.01%) ⬆️ Carriedforward from 0a49748
e2e-stable 57.25% <0.00%> (+0.08%) ⬆️
unit 38.70% <0.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...c/plugins/autoflow/AutoflowTabularRowController.js 17.85% <0.00%> (-0.67%) ⬇️
src/plugins/gauge/components/Gauge.vue 62.20% <ø> (-0.37%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ece4e5...69fec89. Read the comment docs.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 21, 2023
@shefalijoshi shefalijoshi merged commit 6db390a into master Aug 21, 2023
7 checks passed
@shefalijoshi shefalijoshi deleted the fix-strategy-latest-misses branch August 21, 2023 21:09
shefalijoshi added a commit that referenced this pull request Aug 21, 2023
ozyx pushed a commit that referenced this pull request Aug 22, 2023
…tabular and gauge views (#6981)

cherry-pick(#6960): Add strategy latest and timeContext to auto flow tabular and gauge views (#6960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants