cherry-pick(#6919): Fix remote clock subscription #6934
Conversation
* If there are no listeners for this clock then don't bother subscribing after getting the domain object details * Comment explaining the fix
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/16/2023 10:41:15pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: c89f0db Started: 08/16/2023 10:37:26pm UTC Current Playwright Test Results Summary✅ 135 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/16/2023 10:41:15pm UTC) |
| // The start method is called when at least one listener registers with the clock. | ||
| // When the clock is changed, listeners are unregistered from the clock and the stop method is called. | ||
| // Sometimes, the objects.get call above does not resolve before the stop method is called. | ||
| // So when we proceed with the clock subscription below, we first need to ensure that there is at least one listener for our clock. |
Codecov Report
@@ Coverage Diff @@
## release/3.0.1 #6934 +/- ##
================================================
Coverage ? 42.00%
================================================
Files ? 409
Lines ? 12664
Branches ? 0
================================================
Hits ? 5320
Misses ? 7344
Partials ? 0
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
If there are no listeners for this clock then don't bother subscribing after getting the domain object details
Comment explaining the fix
VIPEROMCT-394