Condition sets now provide the timeContext they're using when sending requests #6929
Conversation
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/15/2023 05:32:19pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 86da66d Started: 08/15/2023 05:30:25pm UTC Current Playwright Test Results Summary✅ 133 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/15/2023 05:32:19pm UTC)
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0.76% (1)1 / 131 runfailed over last 7 days |
45.04% (59)59 / 131 runsflaked over last 7 days |
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 128 runsfailed over last 7 days |
42.97% (55)55 / 128 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6929 +/- ##
==========================================
- Coverage 48.39% 48.35% -0.04%
==========================================
Files 643 643
Lines 25629 25629
Branches 2496 2496
==========================================
- Hits 12402 12393 -9
- Misses 12752 12760 +8
- Partials 475 476 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
@shefalijoshi blocked due to failing unit test |
|
@shefalijoshi let's cherry-pick this one onto release/3.0.1 before we forget |
… using when sending requests (#6929) * Send in the timeContext for requests * Fix failing test --------- Co-authored-by: Scott Bell <[email protected]>
…e using when sending requests (#6959) cherry-pick(6929): Condition sets now provide the timeContext they're using when sending requests (#6929) * Send in the timeContext for requests * Fix failing test --------- Co-authored-by: Scott Bell <[email protected]>
Closes #6928
Describe your changes:
Send in the timeContext as request options for lad requests from condition sets. Some providers (like Yamcs) use the information from the timeContext (realtime vs fixed timespan mode etc.).
All Submissions:
Author Checklist
Reviewer Checklist