Recent objects do not update when object names are changed #6927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-do-not-update-when-object-names-are-changed
7 tasks
|
@ozyx if this looks good from a code perspective, I'll start adding some e2e tests: Screen.Recording.2023-08-14.at.3.21.51.PM.movNote I haven't addressed the |
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/16/2023 09:37:54pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 8ae06f9 Started: 08/16/2023 09:36:00pm UTC Current Playwright Test Results Summary✅ 136 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/16/2023 09:37:54pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Plot Tagging Tags work with Overlay Plots
Retry 2 • Retry 1 • Initial Attempt |
10.26% (16)16 / 156 runsfailed over last 7 days |
26.28% (41)41 / 156 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 188 runsfailed over last 7 days |
55.85% (105)105 / 188 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6927 +/- ##
==========================================
+ Coverage 48.26% 48.28% +0.01%
==========================================
Files 643 643
Lines 25631 25700 +69
Branches 2496 2509 +13
==========================================
+ Hits 12372 12409 +37
- Misses 12783 12811 +28
- Partials 476 480 +4
*This pull request uses carry forward flags. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
7 tasks
ozyx
reviewed
Aug 16, 2023
unlikelyzero
approved these changes
Aug 16, 2023
…ect-names-are-changed
ozyx
deleted the
6818-recent-objects-do-not-update-when-object-names-are-changed
branch
scottbell
added a commit
that referenced
this pull request
Aug 17, 2023
* fix tree name issue * add name to key, and name observers to recent objects * no need to change key * make more of app reactive to name changes * fix browse bar and document title * listen in properties for name changes * add tests for renaming * yeah spelling linter * add semantic tags to forms and fixup tests * change purpose * actually delete the listener * ensuring deletion --------- Co-authored-by: Jesse Mazzella <[email protected]>
ozyx
added a commit
that referenced
this pull request
Aug 17, 2023
…e changed (#6949) Recent objects do not update when object names are changed (#6927) * fix tree name issue * add name to key, and name observers to recent objects * no need to change key * make more of app reactive to name changes * fix browse bar and document title * listen in properties for name changes * add tests for renaming * yeah spelling linter * add semantic tags to forms and fixup tests * change purpose * actually delete the listener * ensuring deletion --------- Co-authored-by: Jesse Mazzella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6818
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist