fix: remove tree-item-destroyed event
#6856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Composition listeners should only be removed if the item has been deleted or its parent has been collapsed. Both are handled by `mct-tree` already, so doing this additionally when tree-items unmount is redundant. - In addition to that, any time the `visibleTreeItems` array changes, all tree-items will unmount, so this just doesn't work as intended-- it will unregister all composition listeners whenever the tree changes!
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/30/2023 06:51:50am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: ccc96e5 Started: 07/30/2023 06:49:57am UTC Current Playwright Test Results Summary✅ 131 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/30/2023 06:51:50am UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1 • Initial Attempt |
9.72% (7)7 / 72 runsfailed over last 7 days |
33.33% (24)24 / 72 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 62 runsfailed over last 7 days |
20.97% (13)13 / 62 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
4.35% (4)4 / 92 runsfailed over last 7 days |
7.61% (7)7 / 92 runsflaked over last 7 days |
- Use keyboard gestures to navigate
Codecov Report
@@ Coverage Diff @@
## master #6856 +/- ##
==========================================
- Coverage 48.27% 48.22% -0.05%
==========================================
Files 643 643
Lines 25619 25618 -1
Branches 2507 2507
==========================================
- Hits 12367 12355 -12
- Misses 12761 12785 +24
+ Partials 491 478 -13
*This pull request uses carry forward flags. Click here to find out more.
... and 33 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
khalidadil
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6838
Describe your changes:
Composition listeners should only be removed if the item has been deleted or its parent has been collapsed. Both are handled by
mct-treealready, so doing this additionally when tree-items unmount is redundant.In addition to that, any time the
visibleTreeItemsarray changes, all tree-items will unmount, so this just doesn't work as intended-- it will unregister all composition listeners whenever the tree changes!This recently started cropping up because of a typo I had fixed in tree-item.vue, so this was never firing before-- otherwise we would have caught this issue way sooner.
All Submissions:
Author Checklist
Reviewer Checklist