-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch Couch DB create calls #6779
Conversation
Current Playwright Test Results Summary✅ 13 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/12/2023 04:35:45am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: d3e8669 Started: 07/12/2023 04:31:48am UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt |
14.29% (4)4 / 28 runsfailed over last 7 days |
67.86% (19)19 / 28 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 123 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 07/12/2023 04:35:45am UTC)
⚠️ Flakes
📄 functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Autoscale User can set autoscale with a valid range @snapshot
Retry 1 • Initial Attempt |
32.10% (26)26 / 81 runsfailed over last 7 days |
3.70% (3)3 / 81 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
4.71% (4)4 / 85 runsfailed over last 7 days |
76.47% (65)65 / 85 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
However, this doesn't seem to have fixed the issue VIPEROMCT-345 completely. (Admittedly I tested this on Firefox)
Open MCT froze on and off while trying to complete the large import. That said, the browser did not crash.
If this is the desired outcome, then we should merge this.
Apparently the freezing is a different issue that's being fixed elsewhere. The error mentioned in the linked issue is no longer visible, so I'm merging this. |
Codecov Report
@@ Coverage Diff @@
## master #6779 +/- ##
==========================================
+ Coverage 53.74% 53.83% +0.09%
==========================================
Files 624 624
Lines 24879 24867 -12
Branches 2498 2493 -5
==========================================
+ Hits 13370 13387 +17
+ Misses 10841 10812 -29
Partials 668 668
*This pull request uses carry forward flags. Click here to find out more.
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Closes VIPEROMCT-345
Describe your changes:
Implements persistence batching via debouncing for the Couch
create
action which in the case of Import From JSON can result in a very large number of POST requests to the Couch server.All Submissions:
Author Checklist
Reviewer Checklist