Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]Add docker and npm caching #6748

Merged
merged 40 commits into from
Jun 21, 2023
Merged

[CI]Add docker and npm caching #6748

merged 40 commits into from
Jun 21, 2023

Conversation

unlikelyzero
Copy link
Collaborator

@unlikelyzero unlikelyzero commented Jun 20, 2023

Closes: ##4908

Describe your changes:

Adds some docker layer and npm caching
Driveby: update windows prettier config
Driveby: update to node18

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@unlikelyzero unlikelyzero changed the title Add docker and npm caching [CI]Add docker and npm caching Jun 20, 2023
@unlikelyzero unlikelyzero added this to the Target:2.2.6 milestone Jun 20, 2023
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 20, 2023
@deploysentinel
Copy link

deploysentinel bot commented Jun 20, 2023

Current Playwright Test Results Summary

✅ 122 Passing - ❌ 1 Failing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/21/2023 08:53:58pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: cab322f

Started: 06/21/2023 08:48:43pm UTC

❌ Failures

📄   framework/baseFixtures.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
baseFixtures tests Verify that tests fail if console.error is thrown
Initial Attempt
Error: Console error detected: [error] This should result in a failure at ( 0:14)...
Console error detected: [error] This should result in a failure at ( 0:14)

Expected: not "error"

100% (137) 137 / 137 runs
failed over last 7 days
0% (0) 0 / 137 runs
flaked over last 7 days

⚠️ Flakes

📄   functional/plugins/timeConductor/timeConductor.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time conductor input fields real-time mode validate input fields in real-time mode
Retry 1Initial Attempt
0% (0) 0 / 91 runs
failed over last 7 days
1.10% (1) 1 / 91 run
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 101 runs
failed over last 7 days
4.95% (5) 5 / 101 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1Initial Attempt
0.97% (1) 1 / 103 run
failed over last 7 days
46.60% (48) 48 / 103 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #6748 (3bb7fdc) into master (d8ac209) will decrease coverage by 1.00%.
The diff coverage is n/a.

❗ Current head 3bb7fdc differs from pull request most recent head cab322f. Consider uploading reports for the commit cab322f to get more accurate results

@@            Coverage Diff             @@
##           master    #6748      +/-   ##
==========================================
- Coverage   53.75%   52.76%   -1.00%     
==========================================
  Files         624      624              
  Lines       24848    24847       -1     
  Branches     2493     2493              
==========================================
- Hits        13357    13110     -247     
- Misses      10824    11069     +245     
- Partials      667      668       +1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.14% <ø> (ø) Carriedforward from b6d6133
e2e-stable 50.49% <ø> (-4.77%) ⬇️
unit 48.52% <ø> (+0.05%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ac209...cab322f. Read the comment docs.

@unlikelyzero unlikelyzero added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Jun 20, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 20, 2023
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 20, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 20, 2023
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 20, 2023
@unlikelyzero unlikelyzero added pr:e2e Automatically triggers e2e tests to run pr:platform Runs tests against all supported platforms labels Jun 20, 2023
@github-actions
Copy link

@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 20, 2023
@unlikelyzero unlikelyzero added pr:platform Runs tests against all supported platforms and removed pr:e2e Automatically triggers e2e tests to run pr:platform Runs tests against all supported platforms labels Jun 20, 2023
@unlikelyzero unlikelyzero removed the pr:platform Runs tests against all supported platforms label Jun 20, 2023
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Jun 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 21, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 21, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 21, 2023
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Jun 21, 2023
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Jun 21, 2023
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Jun 21, 2023
@ozyx ozyx self-requested a review June 21, 2023 20:42
@ozyx
Copy link
Contributor

ozyx commented Jun 21, 2023

Had to remove ${{ }} from the if: conditionals due to this long-standing bug with github actions runner.

@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Jun 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 21, 2023
@unlikelyzero unlikelyzero merged commit b685b95 into master Jun 21, 2023
@unlikelyzero unlikelyzero deleted the caching-for-workflows branch June 21, 2023 20:54
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants