Role selection for operator status roles #6706
Conversation
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/14/2023 07:10:42pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: a80b094 Started: 07/14/2023 07:07:40pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt |
10.87% (5)5 / 46 runsfailed over last 7 days |
67.39% (31)31 / 46 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 133 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 07/14/2023 07:10:42pm UTC)
⚠️ Flakes
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
0.62% (1)1 / 162 runfailed over last 7 days |
80.86% (131)131 / 162 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6706 +/- ##
==========================================
- Coverage 53.76% 53.72% -0.05%
==========================================
Files 628 631 +3
Lines 25027 25116 +89
Branches 2508 2516 +8
==========================================
+ Hits 13457 13494 +37
- Misses 10897 10947 +50
- Partials 673 675 +2
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Per the implementation notes, StatusAPI.getStatusRoleForCurrentUser() should be completely removed.
getStatusRoleForCurrentUser is now removed and all dependencies of it canProvideStatusForRole with the role provided from the UserAPI. |
Closes #6555
Describe your changes:
Added a role selection component to enable a user to select from available roles and the option to Change Roles from the navbar. The selected role is persisted through session storage and propagated across open tabs using a BroadcastChannel. A non-status reporting role can be selected and any attempts to select one will be rejected and an error notification will be triggered. One potential improvement is to hide the ability to provide a status response from the taskbar. Currently statuses roles (from operator status plugin) and user roles (from user providers) are provided separately and not necessarily 1:1 in matching roles. The ExampleUserProvider was updated to support multiple roles / statuses. Openmct-YAMCS's user provider was updated to match the UserAPI changes in a companion ticket.
If there are more than one possible roles, users should be prompted immediately to select a role if one is not available via session storage. If only one option, the role should be auto selected.
Areas for improvement:
All Submissions:
Author Checklist
Reviewer Checklist