Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Overlay Plots] Cannot Remove Elements from a Plot #7456

Closed
4 of 7 tasks
rukmini-bose opened this issue Feb 2, 2024 · 3 comments · Fixed by #7516
Closed
4 of 7 tasks

[Overlay Plots] Cannot Remove Elements from a Plot #7456

rukmini-bose opened this issue Feb 2, 2024 · 3 comments · Fixed by #7516
Assignees
@ozyx
Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@rukmini-bose
Copy link
Contributor

rukmini-bose commented Feb 2, 2024 •
edited
Loading

Summary

We currently cannot remove elements from an Overlay Plot if the plot is in view. If we attempt to remove it from the Element Pool or through the Object Tree, this error is thrown:
Screenshot 2024-02-02 at 9 54 52 AM

The only workaround is to navigate away from the object, and remove the elements through the Object Tree.

Expected vs Current Behavior

We should be able to remove elements from a plot.

Steps to Reproduce

  1. Create or Navigate to an Overlay Plot with multiple elements in it. Open your console.
  2. Go to Edit Mode, and in the Elements Pool, right click one of the elements and press "remove".
  3. Observe that there is an error thrown in the console, similar to the image above.
  4. Save the object and refresh. Observe that the element you tried to remove, has indeed, NOT been removed.
  5. Now, go to the object tree and try to remove an element from the Overlay Plot from there.
  6. Repeat 3 and 4.

Environment

  • Open MCT Version: 3.3.0
  • Deployment Type: /testathon, commit hash 5e3b051
  • OS:
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@rukmini-bose rukmini-bose added type:bug severity:blocker bug:regression It used to work. Now it doesn't :( labels Feb 2, 2024
@rukmini-bose rukmini-bose changed the title [Overlay Plots] Cannot Remove Elements from Elements Pool [Overlay Plots] Cannot Remove Elements from a Plot Feb 2, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Feb 2, 2024
@ozyx ozyx self-assigned this Feb 6, 2024
ozyx added a commit that referenced this issue Feb 20, 2024
@ozyx
fix(#7456): check if object is an identifier
8da60c3
@ozyx ozyx mentioned this issue Feb 20, 2024
Merged
15 tasks
ozyx added a commit that referenced this issue Feb 21, 2024
@ozyx
fix(#7456): check if object is an identifier
40bff18
ozyx added a commit that referenced this issue Feb 22, 2024
@ozyx
fix(#7456): allow children of Overlay Plots to be removed (#7516)
29d83e9 
* fix(#7456): check if object is an identifier

* refactor: use v-show, remove unnecessary deep copy, set yAxes array to empty in a way that preserves reactivity

* refactor: use ESM exports

* refactor: use ESM imports

* test(e2e): add test for element item removal from overlay plot

* a11y: add accessible name for object labels

* refactor: move overlayPlot creation to beforeAll, use getByLabel
@rukmini-bose
Copy link
Contributor Author

rukmini-bose commented Feb 27, 2024 •
edited
Loading

TESTING INSTRUCTIONS:

  1. Create or Navigate to an Overlay Plot with multiple elements in it. Open your console.
  2. Go to Edit Mode, and in the Elements Pool, right click one of the elements and press "remove".
  3. Verify that the element is indeed deleted from the Elements Pool and the plot.
  4. Verify that there are no errors in the console.
  5. Save the object and refresh. Verify that the element you tried to remove, is removed.

@ozyx
Copy link
Contributor

ozyx commented Feb 27, 2024

Also verify that removing the element from the object tree action menu works properly and throws no errors

@rukmini-bose
Copy link
Contributor Author

Verified Testathon 2/27/2024, looks gucci

@shefalijoshi shefalijoshi added the verified Tested or intentionally closed label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozyx ozyx

Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging a pull request may close this issue.

fix(#7456): allow children of Overlay Plots to be removed nasa/openmct
3 participants
@shefalijoshi @ozyx @rukmini-bose