Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cabal package homepage points to NASA.gov instead of pointing to repo #147

Closed
ivanperez-keera opened this issue May 23, 2024 · 6 comments
Closed
Assignees
Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Bug Admin only: Change request pertaining to error detected
Milestone

Comments

@ivanperez-keera
Copy link
Member

ivanperez-keera commented May 23, 2024

Description

The cabal files indicate http://nasa.gov as the homepage for all packages. However, we don't really have an Ogma homepage on NASA gov, so it makes no sense to point to that website.

It should instead be replaced with a pointer to this repository.

Type

  • Bug: Cabal packages point to website that does not contain information on Ogma.

Additional context

None.

Requester

  • Ivan Perez

Method to check presence of bug

The following script checks whether https://nasa.gov is set as the homepage for any cabal packages:

$ grep -nHre '^homepage\s*:\s*http\(s\)\?:\/\/nasa.gov$' --include='*.cabal'
ogma-language-jsonspec/ogma-language-jsonspec.cabal:36:homepage:            http://nasa.gov
ogma-extra/ogma-extra.cabal:36:homepage:            http://nasa.gov
ogma-language-c/ogma-language-c.cabal:36:homepage:            http://nasa.gov
ogma-core/ogma-core.cabal:36:homepage:            http://nasa.gov
ogma-language-copilot/ogma-language-copilot.cabal:36:homepage:            http://nasa.gov
ogma-language-cocospec/ogma-language-cocospec.cabal:36:homepage:            http://nasa.gov
ogma-cli/ogma-cli.cabal:36:homepage:            http://nasa.gov
ogma-language-smv/ogma-language-smv.cabal:36:homepage:            http://nasa.gov
ogma-spec/ogma-spec.cabal:36:homepage:            http://nasa.gov

Expected result

Running the above grep command prints nothing, indicating that no cabal page lists http://nasa.gov as the homepage.

Desired result

Running the above grep command prints nothing, indicating that no cabal page lists http://nasa.gov as the homepage.

Proposed solution

Set the homepage to this repo's URL in all cabal packages.

Further notes

None.

@ivanperez-keera ivanperez-keera added CR:Status:Initiated Admin only: Change request that has been initiated CR:Type:Bug Admin only: Change request pertaining to error detected labels Sep 22, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Confirmed that the issue exists.

@ivanperez-keera ivanperez-keera added CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager and removed CR:Status:Initiated Admin only: Change request that has been initiated labels Sep 22, 2024
@ivanperez-keera
Copy link
Member Author

Technical Lead: Confirmed that the issue should be addressed.

@ivanperez-keera ivanperez-keera added CR:Status:Accepted Admin only: Change request accepted by technical lead and removed CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager labels Sep 22, 2024
@ivanperez-keera
Copy link
Member Author

ivanperez-keera commented Sep 22, 2024

Technical Lead: Issue scheduled for fixing in Ogma 1.4.1.

Fix assigned to: @ivanperez-keera.

@ivanperez-keera ivanperez-keera added CR:Status:Scheduled Admin only: Change requested scheduled and removed CR:Status:Accepted Admin only: Change request accepted by technical lead labels Sep 22, 2024
@ivanperez-keera ivanperez-keera added this to the 1.5.0 milestone Sep 22, 2024
@ivanperez-keera ivanperez-keera self-assigned this Sep 22, 2024
@ivanperez-keera ivanperez-keera added CR:Status:Implementation Admin only: Change request that is currently being implemented and removed CR:Status:Scheduled Admin only: Change requested scheduled labels Sep 22, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
The cabal files indicate http://nasa.gov as the homepage for all
packages. However, we don't really have an Ogma homepage on NASA gov, so
it makes no sense to point to that website.

This commit replaces the cabal file's homepage to point to Ogma's repo's
URL.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
The cabal files indicate http://nasa.gov as the homepage for all
packages. However, we don't really have an Ogma homepage on NASA gov, so
it makes no sense to point to that website.

This commit replaces the cabal file's homepage to point to Ogma's repo's
URL.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
The cabal files indicate http://nasa.gov as the homepage for all
packages. However, we don't really have an Ogma homepage on NASA gov, so
it makes no sense to point to that website.

This commit replaces the cabal file's homepage to point to Ogma's repo's
URL.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
The cabal files indicate http://nasa.gov as the homepage for all
packages. However, we don't really have an Ogma homepage on NASA gov, so
it makes no sense to point to that website.

This commit replaces the cabal file's homepage to point to Ogma's repo's
URL.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
The cabal files indicate http://nasa.gov as the homepage for all
packages. However, we don't really have an Ogma homepage on NASA gov, so
it makes no sense to point to that website.

This commit replaces the cabal file's homepage to point to Ogma's repo's
URL.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
The cabal files indicate http://nasa.gov as the homepage for all
packages. However, we don't really have an Ogma homepage on NASA gov, so
it makes no sense to point to that website.

This commit replaces the cabal file's homepage to point to Ogma's repo's
URL.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
The cabal files indicate http://nasa.gov as the homepage for all
packages. However, we don't really have an Ogma homepage on NASA gov, so
it makes no sense to point to that website.

This commit replaces the cabal file's homepage to point to Ogma's repo's
URL.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
The cabal files indicate http://nasa.gov as the homepage for all
packages. However, we don't really have an Ogma homepage on NASA gov, so
it makes no sense to point to that website.

This commit replaces the cabal file's homepage to point to Ogma's repo's
URL.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
The cabal files indicate http://nasa.gov as the homepage for all
packages. However, we don't really have an Ogma homepage on NASA gov, so
it makes no sense to point to that website.

This commit replaces the cabal file's homepage to point to Ogma's repo's
URL.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Sep 22, 2024
@ivanperez-keera
Copy link
Member Author

Implementor: Solution implemented, review requested.

@ivanperez-keera ivanperez-keera added CR:Status:Verification Admin only: Change request that is currently being verified and removed CR:Status:Implementation Admin only: Change request that is currently being implemented labels Sep 22, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Verified that:

  • Solution is implemented:
  • Implementation is documented. Details:
    No need for updates to documentation.
  • Change history is clear.
  • Commit messages are clear.
  • Changelogs are updated.
  • Examples are updated. Details:
    No examples affected.
  • Required version bumps are evaluated. Details:
    No update needed, change to element in cabal file that does not affect behavior.

@ivanperez-keera
Copy link
Member Author

Change Manager: Implementation ready to be merged.

@ivanperez-keera ivanperez-keera added CR:Status:Closed Admin only: Change request that has been completed and removed CR:Status:Verification Admin only: Change request that is currently being verified labels Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Bug Admin only: Change request pertaining to error detected
Projects
None yet
Development

No branches or pull requests

1 participant