Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogma-cli: Structure of variable DB files for ROS is not explained #143

Closed
ivanperez-keera opened this issue May 22, 2024 · 6 comments
Closed
Assignees
Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Bug Admin only: Change request pertaining to error detected
Milestone

Comments

@ivanperez-keera
Copy link
Member

Description

The README does not explain the structure that the variable DB files for ROS should have. Because ogma doesn't give much information to users when a variable cannot be found in the var DB, users do not know what to put in each field in the variable DB, and what effect it will have in the program.

Type

  • Bug: README does not give sufficient documentation.

Additional context

None.

Requester

  • Ivan Perez

Method to check presence of bug

The issue is with the documentation. There is no good, simple automated way to check that it is correct.

Because it's not a programming issue, visual inspection is OK.

Expected result

The README explains the meaning of the fields in the variable DB when used with the ROS backend, and gives an example.

Desired result

The README explains the meaning of the fields in the variable DB when used with the ROS backend, and gives an example.

Proposed solution

Add a subsection to the ROS section of the README explaining the structure of the variable DB.

Further notes

None.

@ivanperez-keera ivanperez-keera added CR:Status:Initiated Admin only: Change request that has been initiated CR:Type:Bug Admin only: Change request pertaining to error detected labels May 22, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Confirmed that the issue exists.

@ivanperez-keera ivanperez-keera added CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager and removed CR:Status:Initiated Admin only: Change request that has been initiated labels May 22, 2024
@ivanperez-keera
Copy link
Member Author

Technical Lead: Confirmed that the issue should be addressed.

@ivanperez-keera ivanperez-keera added CR:Status:Accepted Admin only: Change request accepted by technical lead and removed CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager labels May 22, 2024
@ivanperez-keera
Copy link
Member Author

Technical Lead: Issue scheduled for fixing in Ogma 1.4.

Fix assigned to: @ivanperez-keera.

@ivanperez-keera ivanperez-keera added CR:Status:Scheduled Admin only: Change requested scheduled and removed CR:Status:Accepted Admin only: Change request accepted by technical lead labels May 22, 2024
@ivanperez-keera ivanperez-keera added this to the 1.4.0 milestone May 22, 2024
@ivanperez-keera ivanperez-keera self-assigned this May 22, 2024
@ivanperez-keera ivanperez-keera added CR:Status:Implementation Admin only: Change request that is currently being implemented and removed CR:Status:Scheduled Admin only: Change requested scheduled labels May 22, 2024
ivanperez-keera added a commit that referenced this issue May 22, 2024
The README does not explain the structure that the variable DB files for
ROS should have. Because ogma doesn't give much information to users
when a variable cannot be found in the var DB, users do not know what to
put in each field in the variable DB, and what effect it will have in
the program.

This commit adds a subsection to the ROS section of the README
explaining the structure and format of the variable DB.
@ivanperez-keera
Copy link
Member Author

Implementor: Solution implemented, review requested.

@ivanperez-keera ivanperez-keera added CR:Status:Verification Admin only: Change request that is currently being verified and removed CR:Status:Implementation Admin only: Change request that is currently being implemented labels May 22, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Verified that:

@ivanperez-keera
Copy link
Member Author

Change Manager: Implementation ready to be merged.

@ivanperez-keera ivanperez-keera added CR:Status:Closed Admin only: Change request that has been completed and removed CR:Status:Verification Admin only: Change request that is currently being verified labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Bug Admin only: Change request pertaining to error detected
Projects
None yet
Development

No branches or pull requests

1 participant