Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ogma-cli: Add dockerfile with complete workflow for ROS 2 backend including compiling the ROS app #136

Closed
ivanperez-keera opened this issue Apr 1, 2024 · 6 comments
Closed

ogma-cli: Add dockerfile with complete workflow for ROS 2 backend including compiling the ROS app #136

ivanperez-keera opened this issue Apr 1, 2024 · 6 comments
Assignees
@ivanperez-keera
Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Feature Admin only: Change request pertaining to new features requested
Milestone
1.4.0

Comments

@ivanperez-keera
Copy link
Member

ivanperez-keera commented Apr 1, 2024 •
edited
Loading

Description

Ogma doesn't currently generate a Dockerfile with the ROS packages. That makes it harder for users to know how to use the produce of Copilot.

Type

  • Feature: Complementing new feature.

Additional context

None.

Requester

  • Ivan Perez

Method to check presence of bug

Not applicable (not a bug).

Expected result

Running the ROS command should produce a Dockerfile with the ROS package that can be used to compile the package.

Desired result

Running the ROS command should produce a Dockerfile with the ROS package that can be used to compile the package.

Proposed solution

Add a dockerfile to the list of files produced.

Further notes

None.
@ivanperez-keera ivanperez-keera added CR:Status:Initiated Admin only: Change request that has been initiated CR:Type:Feature Admin only: Change request pertaining to new features requested labels May 20, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Confirmed that the issue exists.

@ivanperez-keera ivanperez-keera added CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager and removed CR:Status:Initiated Admin only: Change request that has been initiated labels May 20, 2024
@ivanperez-keera
Copy link
Member Author

Technical Lead: Confirmed that the issue should be addressed.

@ivanperez-keera ivanperez-keera added CR:Status:Accepted Admin only: Change request accepted by technical lead and removed CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager labels May 20, 2024
@ivanperez-keera
Copy link
Member Author

Technical Lead: Issue scheduled for fixing in Ogma 1.4.

Fix assigned to: @ivanperez-keera.

@ivanperez-keera ivanperez-keera added CR:Status:Scheduled Admin only: Change requested scheduled and removed CR:Status:Accepted Admin only: Change request accepted by technical lead labels May 20, 2024
@ivanperez-keera ivanperez-keera self-assigned this May 20, 2024
@ivanperez-keera ivanperez-keera added this to the 1.4.0 milestone May 20, 2024
@ivanperez-keera ivanperez-keera added CR:Status:Implementation Admin only: Change request that is currently being implemented and removed CR:Status:Scheduled Admin only: Change requested scheduled labels May 20, 2024
ivanperez-keera added a commit that referenced this issue May 20, 2024
@ivanperez-keera
ogma-core: Move files to subdirectory. Refs #136.
b8a7128
ivanperez-keera added a commit that referenced this issue May 20, 2024
@ivanperez-keera
ogma-core: Generate nodes in new subdirectory. Refs #136.
9e2284f
ivanperez-keera added a commit that referenced this issue May 20, 2024
@ivanperez-keera
ogma-core: Add dockerfile. Refs #136.
dd7404c
ivanperez-keera added a commit that referenced this issue May 20, 2024
@ivanperez-keera
ogma-cli: Demo job for CI. Refs #136.
13c3b6b
ivanperez-keera added a commit that referenced this issue May 20, 2024
@ivanperez-keera
ogma-core: Document changes in CHANGELOG. Refs #136.
c1aad35
ivanperez-keera added a commit that referenced this issue May 20, 2024
@ivanperez-keera
ogma-cli: Document changes in CHANGELOG. Refs #136.
e73ccef
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-core: Move files to subdirectory. Refs #136.
7bc35a8 
Ogma doesn't currently generate a Dockerfile with the ROS packages. That
makes it harder for users to know how to use the produce of
Ogma.

This commit moves the files generated by Ogma into a subdirectory, to
make it easier to place conforming to the expected structure in a ROS
application.
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-cli: Adjust documentation. Refs #136.
941babe 
Adjust README to match new locations of files generated by the `ros`
command.
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-core: Add dockerfile. Refs #136.
6aba0f5 
Ogma doesn't currently generate a Dockerfile with the ROS packages. That
makes it harder for users to know how to use the produce of Ogma.

This commit adds a Dockerfile to the ROS template used by Ogma, and to
the list of files installed with Ogma. The dockerfile simply compiles
the monitoring application inside Space ROS.
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-cli: Document new Dockerfile. Refs #136.
a334a3b 
A prior commit has modified the `ros` command to generate an additional
Dockerfile. This commit adjusts the documentation in the README to let
users know what the Dockerfile is for and how to build the image.
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-cli: Demo job for CI. Refs #136.
b2b7d72 
This commit adds a CI Job that checks that Ogma can generate a ROS
monitoring package, and the package compiles correctly using the
dockerfile generated with the ROS package.
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-core: Document changes in CHANGELOG. Refs #136.
468915a
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-cli: Document changes in CHANGELOG. Refs #136.
392ab55
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-core: Move files to subdirectory. Refs #136.
cbbe7a7 
Moves the files generated by Ogma into a subdirectory, to make it easier
to place them conforming to the expected structure in a ROS application
inside a docker image.
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-cli: Adjust documentation. Refs #136.
9e6ee42 
Adjust README to match new locations of files generated by the `ros`
command.
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-core: Add dockerfile. Refs #136.
c3c5063 
Ogma doesn't currently generate a Dockerfile with the ROS packages. That
makes it harder for users to know how to use the produce of Ogma.

This commit adds a Dockerfile to the ROS template used by Ogma, and to
the list of files installed with Ogma. The dockerfile simply compiles
the monitoring application inside Space ROS.
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-cli: Document new Dockerfile. Refs #136.
d6ccecc 
A prior commit has modified the `ros` command to generate an additional
Dockerfile. This commit adjusts the documentation in the README to let
users know what the Dockerfile is for and how to build the image.
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-cli: Demo job for CI. Refs #136.
d4cff67 
This commit adds a CI Job that checks that Ogma can generate a ROS
monitoring package, and the package compiles correctly using the
dockerfile generated with the ROS package.
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-core: Document changes in CHANGELOG. Refs #136.
333704a
ivanperez-keera added a commit that referenced this issue May 21, 2024
@ivanperez-keera
ogma-cli: Document changes in CHANGELOG. Refs #136.
5d226c9
@ivanperez-keera ivanperez-keera mentioned this issue May 21, 2024
Merged
@ivanperez-keera
Copy link
Member Author

Implementor: Solution implemented, review requested.

@ivanperez-keera ivanperez-keera added CR:Status:Verification Admin only: Change request that is currently being verified and removed CR:Status:Implementation Admin only: Change request that is currently being implemented labels May 21, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Verified that:

@ivanperez-keera
Copy link
Member Author

Change Manager: Implementation ready to be merged.

@ivanperez-keera ivanperez-keera added CR:Status:Closed Admin only: Change request that has been completed and removed CR:Status:Verification Admin only: Change request that is currently being verified labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Feature Admin only: Change request pertaining to new features requested
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
1 participant
@ivanperez-keera