Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#298] OnAIR Integration #402

Open
wants to merge 78 commits into
base: dev
Choose a base branch
from
Open

[nasa/nos3#298] OnAIR Integration #402

wants to merge 78 commits into from

Conversation

kevincbruce
Copy link
Contributor

Integrated SBN, SBN_Client, and OnAIR into NOS3. Verified successful data transmission across SBN and into the OnAIR vehicle_rep.py file for the Sample_HK_TLM packet, and its inset Sample_Device_HK_TLM packet. It should all work out of the box on a git pull, git submodule update --init --recursive, and make cycle.

jstar and others added 30 commits May 9, 2024 10:54
…adjustments to the docker_launch script to launch OnAIR with NOS3
…cessary for communication between cFS and OnAIR
…nAIR to compile alongside NOS3, instead of it having to be compiled separately but run together
…now, it has been necessary to set USER_ID and GROUP_ID equal to 1000 to get the Dockerfile to build properly.
…ace and have the right name so as to make compiling/running as easy as possible
…op, and removed extra OnAIR submodule definition;
…me Resolution. Currently doesn't seem to fully work, and should be improved in the future to be less hacky.
…ively (seems to work better than previous workaround, but still not fully integrated)
…y to the sys path, and added __pycache__ to gitignore
…ution code for SBN and SBN-Client. Still is broken and cycle crashes cFS.
@kevincbruce kevincbruce added DSM Distributed Systems Missions Feature Feature labels Oct 30, 2024
@kevincbruce kevincbruce self-assigned this Oct 30, 2024
@kevincbruce kevincbruce linked an issue Oct 30, 2024 that may be closed by this pull request
3 tasks
Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onAIR will launch but the SBN_CLIENT component has connection errors and drops packets.

@jlucas9 jlucas9 changed the title [nasa/nos3#298] On Air Integration [nasa/nos3#298] OnAIR Integration Nov 4, 2024
Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SBN_CLIENT has connection errors specifically with sbn_client_sockfd,

Full text:
sc_1 - OnAIR

Current Data Headers: ['SAMPLE. CommandErrorCount', 'SAMPLE. CommandCount', 'SAMPLE. DeviceErrorCount', 'SAMPLE. DeviceCount', 'SAMPLE. DeviceEnabled', 'SAMPLE. DeviceHK. DeviceCounter', 'SAMPLE. DeviceHK. DeviceConfig',
'SAMPLE. DeviceHK. DeviceStatus' ]
SBN Adapter ignoring data file (telemetry should be live)
SBN Client library loaded: '<CDLL 'sbn_client.so', handle 55ebdab84d10 at 0x7f25579c9870>'
SBN_Client Resolving Name sc_1_nos_fsw

SBN_Client Resolved sc_1_nos_fsw to 172.18.0.5

SBN_Client Connecting to 172.18.0.5, 2234

connect err = Connection refused
SERVER CONNECT_ERROR: Connect failed error: -1

SBN_CLIENT: ERROR Failed to get sbn_client_sockfd, cannot continue.
SBN_Client_Init error 256

SBN Client init: 256
Enter Create Pipe.

Create Pipe, PipeID Not Null. PipeID: 0

Enter Pipe Tbl If.

Pipe Info:
PipeTbl[i].PipeID: 0
PipeIDPtr: 0
PipeName: cmd_pipe

SBN Client command pipe: 0
SBN Client sbn_load_and_init pipe: c_uint(0)
SBN_Adapter Running
SBN_CLIENT: ERROR SendSubToSbn! !

SBN Client subscribe msg (id 0x8fa): 0

Terminal

NOS3 Igniter - Version ... sc_1 - OnAIR

sc 1 - NOS3 Flight Sof ...

42 Cam (on fortytwo)
2 Cam (on

42 Map (on fortytwo)
ortytwo)

42 Unit Sphere Viewe ...
here Viewe ...

NOS3 Launcher (on 8 ...

Packet Viewer : Form ...

Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to change the duration of the wait in "scripts/onair_launch.sh" to get this to work. At 12 seconds (the value present right now) it does not work; at 20 seconds it works sometimes, and at 30 seconds it always appears to work. My suggestion would be that we leave it at a value useful for most NOS3 VMs, however, and not adjust it to suit my particular case.

It is worth indicating somewhere that this might be a problem for people, though.

@kevincbruce
Copy link
Contributor Author

May be worth bumping the default sleep time up to 15 or 20. Had it at that before I made it tighter in case it was waiting too long, and it did work, so may be worth making the change to that at least. I do plan to make a wiki covering the basics (where to config to grab a particular packet, how to modify that time to tune it to your VM, links to OnAIR documentation, etc) right after we push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DSM Distributed Systems Missions Feature Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OnAIR integration effort
5 participants