Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#339] AIT Reintegration #363

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Conversation

cjjacks
Copy link

@cjjacks cjjacks commented Sep 4, 2024

Re-introduce AIT into nos3

@cjjacks
Copy link
Author

cjjacks commented Sep 4, 2024

This PR contains the specific nos3 changes required for adding AIT as a groundstation. The groundstation itself is composed of two submodules:

Which are the AIT source code and configuration and the AstroUX based UI respectively. The AIT GSW cab be activated by setting gsw equal to ait in the master config file. Once nos3 is built and launched, the UI can then be accessed at http://localhost:80

Please note, that both the UI and AIT sub-modules represent a minimum viable prototype and further development needs to be done to bring them up to the level of COSMOS/OpenC3. In their current form, the AIT/AstroUX UI provides basic telemetry monitoring and commanding. Below are some of the main outstanding issues with AIT and the UI

AIT

1. Some nos3 commands are not implemented because they have string arguments.  
   As far as I know, AIT does not yet support string arguments for commands.
UI

1. Limits and Alerts need to be implemented.
3. The UI needs some performance tuning as it can be sluggish at the default nos3 data rate.
4. Need to add the monitoring dashboard.
5. Session and Security upgrades.

The above should not have any bearing on the changes incoming to nos3.

@jlucas9 jlucas9 self-assigned this Sep 6, 2024
@jlucas9 jlucas9 added Support User Support Feature Feature labels Sep 6, 2024
@jlucas9 jlucas9 changed the base branch from main to nos3#339-AIT September 10, 2024 13:25
@jlucas9 jlucas9 changed the title Issue 339 [nasa/nos3#339] AIT Reintegration Sep 10, 2024
@jlucas9
Copy link
Contributor

jlucas9 commented Sep 10, 2024

Was able to get to build and run by:

  • git clone https://github.com/cjjacks/nos3.git
  • cd ./nos3
  • git checkout issue-339
  • git submodule update --init --recursive
  • Modified ./cfg/nos3-mission.xml to be <gsw>ait</gsw> and <sc-1-cfg>sc-minimal-config.xml</sc-1-cfg>
  • make prep
  • make
  • make launch
  • Open firefox to localhost
  • Add CF_NOOP comand to pass plan, click go

image

Copy link
Contributor

@jlucas9 jlucas9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work for me! Need to do some cleanup and get the code merged into our managed area so redirected merge into nos3#339-AIT branch of NOS3 for further updates and review.

Copy link

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested branch, can open ait in minimal sc config. Also can send noop command. I am approving. I also agree lets make the nos3#339-AIT branch for clean up and merge.

@msuder
Copy link
Contributor

msuder commented Sep 10, 2024

I tested the branch with AIT and minimal sc config also. Successfully sent CFS NOOP. I concur that this PR is ready to merge.

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the earlier guide. Can open AIT, monitor some telemetry, and send a command. However, at some point it did start shifting, losing connection, and I think it eventually seemed to connect with some other satellite. So I'll approve, but I agree that more changes are needed in a separate test branch to clean up before full integration.

@jlucas9 jlucas9 merged commit 963cbcd into nasa:nos3#339-AIT Sep 10, 2024
2 checks passed
@jlucas9
Copy link
Contributor

jlucas9 commented Sep 10, 2024

Thanks again for the submission @cjjacks!

@cjjacks
Copy link
Author

cjjacks commented Sep 11, 2024

No problem @jlucas9 - excited to be a part of this cool project! I plan to keep working on the UI and the backend to hopefully get that up to par with cosmos/openc3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature Support User Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants