Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #90

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Aug 19, 2024

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 1430645 to d1e5d4c Compare September 2, 2024 22:46
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.7 → v0.6.8](astral-sh/ruff-pre-commit@v0.5.7...v0.6.8)
@owenlittlejohns
Copy link
Member

The failure here was ruff detecting some things in the Jupyter notebooks that needed fixing up. This includes:

  • Unused imports (which could be automatically applied).
  • Comparisons of booleans (e.g., just needing if <boolean> rather than if <boolean> == True).
  • An undeclared variable (that has never been gotten to, yet).
  • Some imports needing to be at the top of a cell.

I let pre-commit take care of the unused imports and then manually applied the fixes for the other three points. I've run all affected notebooks against UAT, but would feel more comfortable if someone else also did the same.

@owenlittlejohns
Copy link
Member

Oh - I just realised I also need to bump some image versions. Will do that now.

Copy link
Member

@flamingbear flamingbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These checks all look good and each updated notebook has an associated minor version change. 🚀

@owenlittlejohns owenlittlejohns merged commit 6036f02 into main Oct 7, 2024
1 check passed
@owenlittlejohns owenlittlejohns deleted the pre-commit-ci-update-config branch October 7, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants