HARMONY-1859: Add WKT POINT support in harmony-py. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-durbin
approved these changes
Sep 9, 2024
examples/tutorial.ipynb
Outdated
| @@ -340,6 +340,7 @@ | |||
| "request = Request(\n", | |||
| " collection=collection,\n", | |||
| " spatial=WKT('POLYGON((-140 20, -50 20, -50 60, -140 60, -140 20))'),\n", | |||
| " # spatial=WKT('POINT(-40 10)'),\n", | |||
There was a problem hiding this comment.
I'm not sure if commented out code is likely to confuse people - maybe we could link to read-the-docs in a cell instead that shows an example of all of the supported WKT spatial strings?
ygliuvt
force-pushed
the
harmony-1859
branch
2 times, most recently
from
2c56856
to
f4fc350
Compare
ygliuvt
force-pushed
the
harmony-1859
branch
from
f4fc350
to
5962a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1859
Description
Add WKT POINT support in harmony-py.
Local Test Steps
make examples
Then run tutorial notebook, modify the spatial parameter for the last test to use POINT or MULTIPOINT, e.g.
spatial=WKT('POINT(-40 10)'),or
spatial=WKT('MULTIPOINT((-77 38.9),(-40 10))'),Verify the harmony-py request is submitted as EDR position request in harmony and runs successfully.
PR Acceptance Checklist