Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony 1838 - Clarify supported python versions #91

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Conversation

vinnyinverso
Copy link
Contributor

@vinnyinverso vinnyinverso commented Aug 6, 2024

Jira Issue ID

HARMONY-1838

Description

  1. Clarifies supported python versions (to address What is the minimum python version? #78)

  2. Updates some deprecated GitHub actions.

  3. Modifies the "Tests" GitHub workflow so that detailed HTML code coverage reports are only uploaded to GitHub on pull request open or synchronize events. (For every commit, the tests will still run and the code coverage summary will still be printed to the GitHub actions web UI). If developers want the full HTML coverage report outside of pull requests, it can be generated locally, on demand via make test.

Local Test Steps

run make ci

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

@vinnyinverso vinnyinverso marked this pull request as draft August 6, 2024 20:49
@vinnyinverso vinnyinverso marked this pull request as ready for review August 7, 2024 14:10
Copy link
Contributor

@indiejames indiejames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

@vinnyinverso vinnyinverso merged commit 16280f8 into main Aug 7, 2024
11 checks passed
@vinnyinverso vinnyinverso deleted the harmony-1838 branch August 7, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants