Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Dictionary Integration #173

Merged
merged 29 commits into from
May 22, 2024
Merged

Conversation

thomas-bc
Copy link
Collaborator

@thomas-bc thomas-bc commented Apr 23, 2024

Related Issue(s) nasa/fprime#2592
Has Unit Tests (y/n) y
Documentation Included (y/n)

Change Description

Implements nasa/fprime#2592

@thomas-bc thomas-bc marked this pull request as ready for review May 1, 2024 00:28
@thomas-bc thomas-bc requested a review from LeStarch May 1, 2024 00:28
@thomas-bc thomas-bc linked an issue May 1, 2024 that may be closed by this pull request
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, let us be clear, this is top-rate work. It is also an implementation of a fairly critical subsystem. Thus I made a lot of comments. There is one thing I'd like you to think about: Error checking and resolution.

I want there to be a clear story on what happens and what is returned on malformed JSON data. Given what I see, it is probably a ValueError, or a custom MalformedDictionary error, or a combination. All other errors should be down-converted to a known set of expressive errors.

This will help a lot in determining what to do in the layer above and avoid the random exception problem.

Let me know if you have questions.

src/fprime_gds/executables/utils.py Outdated Show resolved Hide resolved
src/fprime_gds/common/loaders/ch_json_loader.py Outdated Show resolved Hide resolved
src/fprime_gds/common/loaders/json_loader.py Show resolved Hide resolved
src/fprime_gds/common/loaders/json_loader.py Outdated Show resolved Hide resolved
src/fprime_gds/common/loaders/json_loader.py Outdated Show resolved Hide resolved
src/fprime_gds/common/loaders/json_loader.py Outdated Show resolved Hide resolved
src/fprime_gds/common/loaders/json_loader.py Outdated Show resolved Hide resolved
src/fprime_gds/common/loaders/json_loader.py Outdated Show resolved Hide resolved
src/fprime_gds/common/loaders/json_loader.py Outdated Show resolved Hide resolved
@thomas-bc thomas-bc requested a review from LeStarch May 7, 2024 22:47
@LeStarch LeStarch merged commit db2ef3c into nasa:devel May 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate JSON dictionary in the GDS
2 participants