Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing a launch of Flask when -g none is specified. Fixes #2337 #149

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

LeStarch
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

This fixes an issue where -g none would launch Flask and just not open the browser. This had the negative effect that RAM usage would spiral as no clients attached allowing histories to clear.

Now flask will not launch at all. Here is what was tested:

  • Flask does not launch
  • Test API scripts can still run w/o flask
  • fprime-cli telemetry and events still run w/o flask
  • fprime-cli send commands works w/o flask

@LeStarch
Copy link
Collaborator Author

Fixes nasa/fprime#2337

@LeStarch LeStarch merged commit 7c018ce into nasa:devel Oct 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants