Add option to accept comms with FSW running TCP server #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Add a command line option to have the GDS comms adapter act as a client instead of server, thus accepting FSW acting as the TCP server. I wasn't sure what the best --option-name and help_text were... let me know if you have a better idea.
Testing/Review Recommendations
With the option,
server=False
is fed into the constructor here:https://github.com/thomas-bc/fprime-gds/blob/96dd25f02f727ada49ce99160f8b198fe78bb271/src/fprime_gds/common/communication/adapters/base.py#L117-L118