Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #56, Squash int comparison warning #57

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 21, 2020

Describe the contribution
Fix #56 - squash int comparison warning

Testing performed
Build and ran cfe (uses tables built by elf2cfetbl), no issues.

Expected behavior changes
No longer produce the LGTM warning. No behavior change.

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: bundle main (+ cfe/osal main) + this change.

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@astrogeco astrogeco changed the base branch from main to integration-candidate August 26, 2020 23:03
@yammajamma yammajamma added the CCB:Approved Indicates code approval by CCB label Aug 27, 2020
@yammajamma yammajamma merged commit bb16eb1 into nasa:integration-candidate Aug 27, 2020
@skliper skliper deleted the fix56-int-compare-lgtm branch February 1, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code approval by CCB CCB:FastTrack enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LGTM issue - comparison between int16 and int
3 participants