Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ comment style and commented out code violations #70

Closed
zanzaben opened this issue Feb 23, 2021 · 0 comments · Fixed by #71 or #72
Closed

C++ comment style and commented out code violations #70

zanzaben opened this issue Feb 23, 2021 · 0 comments · Fixed by #71 or #72
Assignees
@zanzaben
Labels
bug Something isn't working docs

Comments

@zanzaben
Copy link
Contributor

Is your feature request related to a problem? Please describe.
C++ comment style and commented out code violates style guidelines

elf2cfetbl/elf2cfetbl.c

Line 2269 in 6762b1c

// fseek expects a long int, sh_offset and st_value are uint64 for elf64

Describe the solution you'd like
Clean up

Describe alternatives you've considered
None

Requester Info
Alex Campbell GSFC
@zanzaben zanzaben self-assigned this Feb 23, 2021
zanzaben added a commit to zanzaben/elf2cfetbl that referenced this issue Feb 23, 2021
@zanzaben
Fix nasa#70, fix comment stlye
957863f
@zanzaben zanzaben mentioned this issue Feb 23, 2021
Merged
zanzaben added a commit to zanzaben/elf2cfetbl that referenced this issue Feb 23, 2021
@zanzaben
Fix nasa#70, fix comment stlye
309d655
zanzaben added a commit to zanzaben/elf2cfetbl that referenced this issue Mar 1, 2021
@zanzaben
Fix nasa#70, fix comment stlye
c72ec46
astrogeco added a commit that referenced this issue Mar 1, 2021
@astrogeco
Merge pull request #71 from zanzaben/fix70_fix_comment_style
4f4e070 
Fix #70, fix comment stlye
@astrogeco astrogeco added bug Something isn't working docs labels Mar 1, 2021
@astrogeco astrogeco mentioned this issue Mar 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
bug Something isn't working docs
Projects
None yet
Milestone
No milestone
2 participants
@zanzaben @astrogeco