Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetElfHeader - cyclomatic complexity of 36 #129

Closed
chillfig opened this issue Mar 3, 2023 · 0 comments · Fixed by #136
Closed

GetElfHeader - cyclomatic complexity of 36 #129

chillfig opened this issue Mar 3, 2023 · 0 comments · Fixed by #136
Assignees
@chillfig
Labels
enhancement New feature or request

Comments

@chillfig
Copy link

chillfig commented Mar 3, 2023

Is your feature request related to a problem? Please describe.
NASA guidelines in NPR 7150.2D recommends maintaining a cyclomatic complexity in software, in particular flight software of 15.

elf2cfetbl.c::GetElfHeader unnecessarily violates the recommendation with a cyclomatic complexity of 36.

Describe the solution you'd like
Clean up GetElfHeader such that it has a cyclomatic complexity of 15 or less.

Describe alternatives you've considered
Leave as-is

Additional context
Imported from JSC static analysis audit

Requester Info
Justin Figueroa, Vantage Systems
@chillfig chillfig added the enhancement New feature or request label Mar 3, 2023
chillfig pushed a commit to chillfig/elf2cfetbl that referenced this issue Jul 13, 2023
Fix nasa#129, Reduce cyclomatic complexity of GetElfHeader
b0cba9c
@chillfig chillfig mentioned this issue Jul 13, 2023
Merged
chillfig pushed a commit to chillfig/elf2cfetbl that referenced this issue Jul 17, 2023
Fix nasa#129, Reduce cyclomatic complexity of GetElfHeader
2295974
dzbaker added a commit that referenced this issue Sep 1, 2023
@dzbaker
Merge pull request #136 from chillfig:reduce_cycloComplex
8e5965c 
Fix #129, Reduce cyclomatic complexity of GetElfHeader
@dzbaker dzbaker mentioned this issue Sep 1, 2023
Merged
2 tasks
@dzbaker dzbaker closed this as completed in e0ffd26 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chillfig chillfig

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #129, Reduce cyclomatic complexity of GetElfHeader chillfig/elf2cfetbl
1 participant
@chillfig