Fix #37, termination on strncpy

Fix possible non-termination of strings within command line parsing. This generated a warning in GCC9.
nasa · Apr 27, 2020 · 3f68b98 · 3f68b98
1 parent 3c4be59
commit 3f68b98
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/elf2cfetbl.c b/elf2cfetbl.c
@@ -936,13 +936,15 @@ int32 ProcessCmdLineOptions(int ArgumentCount, char *Arguments[])
         if ((Arguments[i][0] == '-') && (Arguments[i][1] == 't'))
         {
             // Extract the Table Name Override
-            strncpy(TableName, &Arguments[i][2], 38);
+            strncpy(TableName, &Arguments[i][2], sizeof(TableName)-1);
+            TableName[sizeof(TableName)-1] = 0;
             TableNameOverride = true;
         }
         else if ((Arguments[i][0] == '-') && (Arguments[i][1] == 'd'))
         {
             // Extract the Description Override
-            strncpy(Description, &Arguments[i][2], 32);
+            strncpy(Description, &Arguments[i][2], sizeof(Description)-1);
+            Description[sizeof(Description)-1] = 0;
             DescriptionOverride = true;
         }
         else if ((Arguments[i][0] == '-') && (Arguments[i][1] == 's'))