Marc's final feedback on CUMULUS-748 #422
Conversation
| // skip if the file with the same hash is zipped | ||
| // and is a valid zip file | ||
| if (fs.existsSync(lambda.local)) { | ||
| if (await fs.pathExists(lambda.local)) { |
There was a problem hiding this comment.
Use an asynchronous operation instead of hanging the process on the fs.existsSync call.
| try { | ||
| await (util.promisify(yauzl.open))(lambda.local); // Verify yauzl can open the .zip file | ||
| return Promise.resolve(lambda); | ||
| } | ||
| catch (e) { | ||
| console.log(`${lambda.local} appears to be an invalid zip file, and will be re-built`); | ||
| console.log(`${lambda.local} is invalid and will be rebuilt`); |
There was a problem hiding this comment.
Minor change to the message that's logged.
| } | ||
| } | ||
|
|
||
| let msg = `Zipping ${lambda.local}`; |
There was a problem hiding this comment.
Moved this variable declaration down closer to where it's actually used.
| throw (e); | ||
| }); | ||
|
|
||
| try { |
There was a problem hiding this comment.
Since this is an async function, we can use a try/catch to make it a little more explicit what is going on.
| ); | ||
| } | ||
| ); | ||
| test.serial('zipLambda: given an invalid zip file generated from a previous run, a new valid lambda file is generated', async (t) => { // eslint-disable-line max-len |
There was a problem hiding this comment.
Using single quotes for the string, since no string interpolation is being performed. Added // eslint-disable-line max-len to prevent complaints about the long line.
Making this change also changed the indentation of the function, so that's why it looks like there's more changed than there actually is.
Marc's final feedback on CUMULUS-748
No description provided.