CUMULUS-3841: Increase fetchRules page size to improve performance. #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpilone
force-pushed
the
pp/CUMULUS-3841-fetch-rules-page-size
branch
from
ba6af4f
to
c67f76b
Compare
4 tasks
|
Addresses #3772 |
etcart
reviewed
Aug 22, 2024
There was a problem hiding this comment.
can we add to our unit tests a validation of this?
There was a problem hiding this comment.
Updated failing test and added a small one that validates the new argument. Fixed a small doc typo too.
etcart
approved these changes
Aug 22, 2024
Nnaga1
pushed a commit
that referenced
this pull request
Aug 23, 2024
…3779) * Increase limit of records per page to be 100 from fetchRules function * Pass pageSize as a parameter from fetchRules function * minor code cleaning * Adds change log entry * Adds unit tests for fetchRules page size argument * Improves fetchRules pageSize unit test * Fixes linter errors --------- Co-authored-by: Hailiang Zhang <[email protected]>
Nnaga1
added a commit
that referenced
this pull request
Aug 23, 2024
* CUMULUS-3796: Prepare Release 18.4.0 (#3774) * first commit for release-18.4.0 * version v flag in website * fixing docs/sidebar version + small fix --------- Co-authored-by: etcart <[email protected]> * CUMULUS-3840:Fixed @cumulus/api/bin/serve to correctly use EsClient (#3777) * CUMULUS-3841: Increase fetchRules page size to improve performance. (#3779) * Increase limit of records per page to be 100 from fetchRules function * Pass pageSize as a parameter from fetchRules function * minor code cleaning * Adds change log entry * Adds unit tests for fetchRules page size argument * Improves fetchRules pageSize unit test * Fixes linter errors --------- Co-authored-by: Hailiang Zhang <[email protected]> --------- Co-authored-by: etcart <[email protected]> Co-authored-by: jennyhliu <[email protected]> Co-authored-by: Paul Pilone <[email protected]> Co-authored-by: Hailiang Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-3841 Increase fetchRules page limit size to improve overall query performance: Develop amazing new feature
Changes
PR Checklist