Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin tough-cookie dependency to avoid breaking change in 4.1 #3089

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

npauzenga
Copy link
Contributor

@npauzenga npauzenga commented Aug 25, 2022

This pins our direct dependencies for tough-cookie to version ~4.0. There is an issue with the latest minor release 4.1 which is causing unit tests to fail: salesforce/tough-cookie#246

Once the dependency issue is resolved and verified we should switch this back to the latest version.

@npauzenga npauzenga changed the title WIP: pin tough-cookie to avoid breaking change in 4.1 Pin tough-cookie dependency to avoid breaking change in 4.1 Aug 25, 2022
@npauzenga npauzenga merged commit 16b9d83 into master Aug 25, 2022
@npauzenga npauzenga deleted the bug/CUMULUS-1-fix-tough-cookie branch August 25, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants