-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUMULUS-2688: New Granule endpoint GET /:collectionId/:granuleId #2978
CUMULUS-2688: New Granule endpoint GET /:collectionId/:granuleId #2978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a couple of comments/considerations. Let me know what you think, and as always I'm available to pair/discuss anytime.
…ithub.com/nasa/cumulus into feature/CUMULUS-2688-new-granule-endpoint
Thanks @Jkovarik! I replied to your comments and updated where appropriate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my feedback 👍🏻
Summary:
Addresses CUMULUS-2688: Develop amazing new feature
Changes
This is the endpoint update to allow users to fetch granules by their unique columns (
collection_cumulus_id
+granule_id
).The new endpoint is
/:collectionId/:granuleName
wherecollectionId
is in thename___version
format, NOT the collection_cumulus_id. It's done this way because we don't appear to indexcollection_cumulus_id
in ES or return it from our LIST endpoint. This means that users/the dashboard aren't likely to have that ID from previous requests.It would be nicer to use
collection_cumulus_id/granule_id
as the endpoint to save a Collection query but that seems like it would be less useful.These changes are only adding the endpoint, not using the new functions elsewhere. I'd like to do those in a separate PR and maybe a separate ticket for some.
What's left:
collectionId
(likely need new endpoints like we have here)PR Checklist