Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all tests to use test-data package #279

Merged
merged 7 commits into from
Mar 29, 2018
Merged

Update all tests to use test-data package #279

merged 7 commits into from
Mar 29, 2018

Conversation

scisco
Copy link
Contributor

@scisco scisco commented Mar 28, 2018 •
edited
Loading

Summary: Summary of changes

Partly Addresses CUMULUS-301

Changes

  • Update all tests to use data in the test-data package
  • remove .tmp-data folder

Test Plan

Things that should succeed before merging.

  • Unit tests
  • Update CHANGELOG
  • Run ./bin/eslint-ratchet and verify that eslint errors have not increased
    • Commit .eslint-ratchet-high-water-mark if the score has improved

marchuffnagle
marchuffnagle approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@marchuffnagle marchuffnagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@scisco scisco merged commit c70cc42 into master Mar 29, 2018
@scisco scisco deleted the CUMULUS-301 branch March 29, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchuffnagle marchuffnagle marchuffnagle approved these changes

@sethvincent sethvincent Awaiting requested review from sethvincent

@laurenfrederick laurenfrederick Awaiting requested review from laurenfrederick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scisco @marchuffnagle