CUMULUS-436: Add activities support to @cumulus/integration-tests #277
Conversation
| } | ||
|
|
||
| const succeededDetails = JSON.parse(stepExecution.completeEvent[this.eventDetailsKeys.succeeded].output.toString()); | ||
| return succeededDetails; |
There was a problem hiding this comment.
nitpicky, but you don't need to define succeededDetails, you could just return the value.
|
This changes the API for getting the lambda output from |
| @@ -69,11 +69,13 @@ async function waitForCompletedExecution(executionArn) { | |||
| let statusCheckCount = 0; | |||
|
|
|||
| // While execution is running, check status on a time interval | |||
| /* eslint-disable no-await-in-loop */ | |||
There was a problem hiding this comment.
nit: I usually prefer to add the eslint-disable comment on the same line that is causing the error. So, something like this:
await timeout(waitPeriodMs); // eslint-disable-line no-await-in-loop
packages/integration-tests/index.js
Outdated
| @@ -123,7 +125,7 @@ async function startWorkflowExecution(workflowArn, inputFile) { | |||
| async function executeWorkflow(stackName, bucketName, workflowName, inputFile) { | |||
| const workflowArn = await getWorkflowArn(stackName, bucketName, workflowName); | |||
| const execution = await startWorkflowExecution(workflowArn, inputFile); | |||
| const executionArn = execution.executionArn; | |||
| const { executionArn } = execution; | |||
There was a problem hiding this comment.
These two lines could just be
const { executionArn } = await startWorkflowExecution(workflowArn, inputFile);
| return eventScheduled && isStepEvent; | ||
| }); | ||
|
|
||
| if (scheduleEvent === null || scheduleEvent === undefined) { |
There was a problem hiding this comment.
This could just be if (!scheduleEvent) {
|
Thanks @laurenfrederick @yjpa7145 for your reviews! Addressed comments and just waiting for CI to pass before merging. |
Summary: Adds support for testing output of activities in workflow tests
Addresses CUMULUS-436: Cumulus Integration Tests should include an ECS task
Changes
integration-tests/lambda.jswithintegration-tests/sfnStep.jsand removes many reference tolambdasfnStep.jsincludesLambdaStepandActivityStepclasses which inherit fromSfnStepintegration-tests/index.jsTest Plan