Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulus 331 download s3 file non-existent key #276

Merged
merged 5 commits into from
Mar 28, 2018

Conversation

sethvincent
Copy link
Contributor

Summary: Make sure the downloadS3File function catches readstream errors by using pump. Add tests for downloadS3File.

Addresses CUMULUS-331

Changes

  • use pump module to catch errors in both the read and write streams
  • add test for case when key does not exist in bucket
  • add test for case when the key does exist
  • improve jsdocs and variable naming for downloadS3File

Test Plan

Things that should succeed before merging.

  • Unit tests
  • Adhoc testing
  • Update CHANGELOG
  • Run ./bin/eslint-ratchet and verify that eslint errors have not increased
    • Commit .eslint-ratchet-high-water-mark if the score has improved

@@ -1 +1 @@
2059
1530
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to get latest and do an npm install. I think Marc updated the eslint version which caused the spike in errors.

Copy link
Contributor

@kkelly51 kkelly51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scisco scisco merged commit 58d4130 into master Mar 28, 2018
@scisco scisco deleted the cumulus-331-downloadS3File-nonexistant-key branch March 28, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants