Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase memory for CustomBootstrapLambdaFunction #275

Merged
merged 5 commits into from
Mar 22, 2018
Merged

Increase memory for CustomBootstrapLambdaFunction #275

merged 5 commits into from
Mar 22, 2018

Conversation

abarciauskas-bgse
Copy link
Contributor

@abarciauskas-bgse abarciauskas-bgse commented Mar 22, 2018 •
edited
Loading

Summary: Increase memory for CustomBootstrapLambdaFunction

Test Plan

  • Successful deployment successful where the same configuration had failed
  • Testing an instance of this lambda with 256 MB vs more memory failed with the former amount of memory and succeeded with increased memory limit.

Also, you can see the amount of memory lambda tries to use here:

screen shot 2018-03-22 at 3 10 10 pm

laurenfrederick
laurenfrederick reviewed Mar 22, 2018
View reviewed changes
packages/api/config/lambdas.yml Outdated
@@ -99,7 +99,7 @@ jobs:
CustomBootstrap:
handler: index.bootstrap
timeout: 100
memory: 256
memory: 1024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning for 1024 as opposed to say, 512?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason, it's somewhat arbitrary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this affects cost? Maybe? So might be better to keep it on the lower end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right you are! https://aws.amazon.com/lambda/pricing/ good call

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decreased to 512

@abarciauskas-bgse abarciauskas-bgse merged commit 17671d3 into master Mar 22, 2018
@scisco scisco deleted the abarciauskas-bgse_increase-bootstrap-memory branch March 27, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenfrederick laurenfrederick laurenfrederick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abarciauskas-bgse @laurenfrederick