Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add schema dirs to dist dirs #272

Merged
merged 5 commits into from
Mar 28, 2018
Merged

add schema dirs to dist dirs #272

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
519d19d
add schema dirs to dist dirs
sethvincent Mar 22, 2018
9d9bb24
update changelog
sethvincent Mar 22, 2018
a1d6fc6
Merge branch 'master' into cumulus-414-schemas-in-dist
sethvincent Mar 22, 2018
09d43d3
Merge branch 'master' into cumulus-414-schemas-in-dist
sethvincent Mar 23, 2018
7e2c75c
Merge branch 'master' into cumulus-414-schemas-in-dist
Mar 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]
- **CUMULUS-304: "Add AWS API throttling to pdr-status-check task"** Added concurrency limit on SFN API calls. The default concurrency is 10 and is configurable through Lambda environment variable CONCURRENCY.
- **CUMULUS-414: "Schema validation not being performed on many tasks"** revised npm build scripts of tasks that use cumulus-message-adapter to place schema directories into dist directories.

## [v1.2.0] - 2018-03-20

Expand Down
4 changes: 2 additions & 2 deletions cumulus/tasks/discover-granules/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"scripts": {
"test": "ava",
"local": "node index.js | pino",
"build": "webpack --progress",
"watch": "webpack --progress -w",
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress",
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually need to be in the watch step? It only really matters for creating the zip file that's deployed, and that relies on the build step (if I'm correct).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually try to keep the behavior of build and watch really similar. In this case including it as part of watch will be useful for working on tasks when they are npm linked into deployments, which is something I've needed to do before.

"postinstall": "npm run build"
},
"publishConfig": {
Expand Down
4 changes: 2 additions & 2 deletions cumulus/tasks/discover-pdrs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
},
"scripts": {
"test": "ava",
"build": "mkdir -p dist && cp cumulus.json dist/ && webpack --progress",
"watch": "mkdir -p dist && cp cumulus.json dist/ && webpack --progress -w",
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress",
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w",
"postinstall": "npm run build"
},
"publishConfig": {
Expand Down
4 changes: 2 additions & 2 deletions cumulus/tasks/discover-s3-granules/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
"scripts": {
"test": "ava",
"local": "node index.js | pino",
"build": "webpack --progress",
"watch": "webpack --progress -w",
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress",
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w",
"postinstall": "npm run build"
},
"ava": {
Expand Down
4 changes: 2 additions & 2 deletions cumulus/tasks/hello-world/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
},
"scripts": {
"test": "ava tests/*.js --serial --no-color",
"build": "webpack --progress",
"watch": "webpack --progress -w",
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress",
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w",
"postinstall": "npm run build"
},
"publishConfig": {
Expand Down
4 changes: 2 additions & 2 deletions cumulus/tasks/parse-pdr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
},
"scripts": {
"test": "ava",
"build": "webpack --progress",
"watch": "webpack --progress -w",
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress",
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w",
"postinstall": "npm run build"
},
"author": "Cumulus Authors",
Expand Down
4 changes: 2 additions & 2 deletions cumulus/tasks/pdr-status-check/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
},
"scripts": {
"test": "ava",
"build": "webpack --progress",
"watch": "webpack --progress -w",
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress",
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w",
"postinstall": "npm run build"
},
"author": "Cumulus Authors",
Expand Down
4 changes: 2 additions & 2 deletions cumulus/tasks/post-to-cmr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
},
"scripts": {
"test": "ava",
"build": "webpack --progress",
"watch": "webpack --progress -w",
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress",
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w",
"postinstall": "npm run build"
},
"ava": {
Expand Down
4 changes: 2 additions & 2 deletions cumulus/tasks/queue-granules/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
},
"scripts": {
"test": "ava",
"build": "webpack --progress",
"watch": "webpack --progress -w",
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress",
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w",
"postinstall": "npm run build"
},
"ava": {
Expand Down
4 changes: 2 additions & 2 deletions cumulus/tasks/queue-pdrs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
},
"scripts": {
"test": "ava",
"build": "webpack --progress",
"watch": "webpack --progress -w",
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress",
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w",
"postinstall": "npm run build"
},
"ava": {
Expand Down
4 changes: 2 additions & 2 deletions cumulus/tasks/sf-sns-report/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
},
"scripts": {
"test": "ava",
"build": "webpack --progress",
"watch": "webpack --progress -w",
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress",
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w",
"postinstall": "npm run build"
},
"ava": {
Expand Down
4 changes: 2 additions & 2 deletions cumulus/tasks/sync-granule/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
},
"scripts": {
"test": "ava",
"build": "webpack --progress",
"watch": "webpack --progress -w",
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress",
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w",
"postinstall": "npm run build"
},
"author": "Cumulus Authors",
Expand Down