Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUMULUS-337 Rely on NODE_ENV instead of TEST for detecting tests #260

Merged
merged 8 commits into from
Mar 16, 2018

Conversation

marchuffnagle
Copy link
Contributor

Summary: Rely on ava's NODE_ENV=test environment variable to detect a test run

Addresses CUMULUS-337: Update test-specific code to rely on NODE_ENV instead of TEST env vars

Changes

  • Update ava to 0.23.0, which added the NODE_ENV variable
  • Add an inTestMode function to the test-utils module
  • Move the createQueue function from common/test-utils to common/aws to resolve a circular dependency that this change introduced

Test Plan

  • Unit tests
  • Run ./bin/eslint-ratchet and verify that eslint errors have not increased
    • Commit .eslint-ratchet-high-water-mark if the score has improved

@marchuffnagle marchuffnagle merged commit ace231f into master Mar 16, 2018
@marchuffnagle marchuffnagle deleted the CUMULUS-337 branch March 16, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants