CUMULUS-337 Rely on NODE_ENV instead of TEST for detecting tests #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Rely on ava's NODE_ENV=test environment variable to detect a test run
Addresses CUMULUS-337: Update test-specific code to rely on NODE_ENV instead of TEST env vars
Changes
inTestMode
function to thetest-utils
modulecreateQueue
function fromcommon/test-utils
tocommon/aws
to resolve a circular dependency that this change introducedTest Plan
./bin/eslint-ratchet
and verify that eslint errors have not increased.eslint-ratchet-high-water-mark
if the score has improved