Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AWS Integration tests to the core repo #241

Merged
merged 13 commits into from
Mar 13, 2018
Merged

add AWS Integration tests to the core repo #241

merged 13 commits into from
Mar 13, 2018

Conversation

scisco
Copy link
Contributor

@scisco scisco commented Mar 12, 2018

Summary: Summary of changes

Addresses CUMULUS-371

Changes

  • Adds AWS integration tests to circleci Builds

Test Plan

Things that should succeed before merging.

  • Unit tests

cd ~/integration
yarn

# replace latest version of the tasks with existing ones in the integration rep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: integration repo

cat package.json | jq '.dependencies | to_entries[] | select(.key | startswith("@cumulus")).key' > cumulus_integration_tests_packages.txt
cd ~/project

cat ../integration/cumulus_integration_tests_packages.txt | xargs -I % ./node_modules/.bin/lerna exec --scope % -- yarn build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment here would be helpful as well

Copy link
Contributor

@abarciauskas-bgse abarciauskas-bgse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR LGTM however it looks like there is a test result that is unrelated to this PR

@scisco scisco merged commit 7d88e3a into master Mar 13, 2018
@scisco scisco deleted the release-test-pr branch March 13, 2018 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants